feat: limit functionalities for storage pool with driver that's not fully supported in the UI [WD-9345] #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://lxd-ui-708.demos.haus |
mas-who
commented
Mar 22, 2024
| @@ -219,7 +223,7 @@ const StoragePoolForm: FC<Props> = ({ formik, section, setSection }) => { | |||
| readOnly={formik.values.readOnly} | |||
| > | |||
| <Notification severity="information" title="YAML Configuration"> | |||
| This is the YAML representation of the storage pool. | |||
| {`${!supportedStorageDrivers.has(formik.values.driver) ? `The ${formik.values.driver} driver is not fully supported in the web interface. ` : ""}This is the YAML representation of the storage pool.`} | |||
There was a problem hiding this comment.
Thought it would be good to add some info here indicating that the driver for the storage pool is not fully supported in the UI. Open to suggestions for better copy 🙂
mas-who
changed the title
|
@piperdeck I think the easiest way to do a design review for this PR is to jump on a call and go through the changes. Let me know when you have some time? |
edlerd
reviewed
Mar 22, 2024
mas-who
force-pushed
the
lxd-unsupported-storage-driver
branch
from
fbad9f9
to
a8ad838
Compare
edlerd
reviewed
Mar 25, 2024
mas-who
force-pushed
the
lxd-unsupported-storage-driver
branch
from
a8ad838
to
9763c81
Compare
|
Had a design review session with @piperdeck, everything is okay on that front. |
…ully supported in the UI - remove volumes tab in storage detail page - remove main configuration form menu tab and default to show yaml configs editor - filter out storage pool options with unsupported drivers (applies to creating custom volumes, selecting root storage pool for instance and profile, creating custom volume while creating instance, uploading custom iso) Signed-off-by: Mason Hu <mason.hu@canonical.com>
mas-who
force-pushed
the
lxd-unsupported-storage-driver
branch
from
9763c81
to
87cb136
Compare
edlerd
approved these changes
Mar 25, 2024
edlerd
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
lxc storage create cephfs-pool cephfs source=my-filesystem cephfs.create_missing=true cephfs.data_pool=my-data cephfs.meta_pool=my-metadatato create acephfsstorage pool.cephfs-pool. Ensure the volumes tab is gone, ensure main configurations form menu item is gone, try updating the storage pool config using the yaml editor (cephfs.create_missingconfig can be changed without negative consequences)cephfs-pool.cephfs-pool.cephfs-poolas an option