Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use Application Layout components from React Components. #768

Closed
wants to merge 2 commits into from

Conversation

huwshimi
Copy link

Done

  • [List of work items including drive-bys]

Fixes [list issues/bugs if needed]

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • [List the steps to QA the new feature(s) or prove that a bug has been resolved]

Screenshots

[if relevant, include a screenshot or screen capture]

@webteam-app
Copy link

@huwshimi
Copy link
Author

huwshimi commented Jul 2, 2024

These components are now available in react-components: https://canonical.github.io/react-components/?path=/docs/components-applicationlayout--docs.

There are some small changes since this PR was created, but if someone would like to take over this PR that would be great!

@edlerd
Copy link
Collaborator

edlerd commented Jul 3, 2024

These components are now available in react-components: https://canonical.github.io/react-components/?path=/docs/components-applicationlayout--docs.

There are some small changes since this PR was created, but if someone would like to take over this PR that would be great!

Thanks for the update, we'll pick this up in the near future. Might be something for @Kxiru

@Kxiru
Copy link
Contributor

Kxiru commented Sep 4, 2024

Thank you @huwshimi for your implementation and suggestions. This was a great PR to use for reference and we have now successfully incorporated some Application Layout components into LXD-UI. I will now close this PR.
Thanks again!

@Kxiru Kxiru closed this Sep 4, 2024
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants