Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(login) use trust_token as a field name in the payload #811

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Jul 8, 2024

Done

  • fix(login) use trust_token as a field name in the payload
  • when reusing a certificate in case the explicit_trust_token api extension is present

Fixes [list issues/bugs if needed]

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • ensure reusing an old certificate works when talking to a 5.21/stable as well as a 6.1/stable and a latest/candidate backend.

…g a certificate in case the explicit_trust_token api extension is present

Signed-off-by: David Edler <david.edler@canonical.com>
@webteam-app
Copy link

Signed-off-by: David Edler <david.edler@canonical.com>
@mas-who
Copy link
Collaborator

mas-who commented Jul 8, 2024

LGTM 👍

Is it even possible to add a test for adding certificates?

@edlerd
Copy link
Collaborator Author

edlerd commented Jul 8, 2024

Is it even possible to add a test for adding certificates?

It will not be easy, but worthwhile having it. I'll log a task for us to add one.

… > 5

Signed-off-by: David Edler <david.edler@canonical.com>
… the nav is higher than the current screen

Signed-off-by: David Edler <david.edler@canonical.com>
@edlerd edlerd merged commit 9704aea into canonical:main Jul 8, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 8, 2024
@edlerd edlerd deleted the explicit-trust-token branch September 4, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants