Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxd-doc improvements #12062

Merged
merged 2 commits into from
Jul 24, 2023
Merged

lxd-doc improvements #12062

merged 2 commits into from
Jul 24, 2023

Conversation

gabrielmougard
Copy link
Contributor

@gabrielmougard gabrielmougard commented Jul 21, 2023 •
edited
Loading

  • Automatic YAML type conversion
  • Better metadata key checking
  • No default .txt output when not specified

@gabrielmougard
lxd/config/generate: Update lxd-doc to support yaml type assertion
4ad14cd 
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
@gabrielmougard
lxddoc: no default .txt output if path not specified
d797a12 
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
@ru-fu ru-fu mentioned this pull request Jul 24, 2023
Merged
ru-fu
ru-fu reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@ru-fu ru-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough about the go tool to actually review the changes, but I've tested #12043 and that seems to work. :)

@tomponline tomponline merged commit f814ba6 into canonical:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ru-fu ru-fu ru-fu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielmougard @ru-fu @tomponline