Storage: Fix ZFS incorrect VM cached image volume regeneration when zfs.block_mode enabled #12077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will use the underlying pool's isBlockBacked() function rather than relying on the pool's static BlockBacking setting, as this may change on a per volume basis. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Removes redundant blockBacked argument and instead relies on the vol.IsBlockBacked function, which uses the pools' underlying isBlockBacked() function rather than using the pools static BlockBacking setting. This allows for block backing setting to be altered on a per-volume basis. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…Image when comparing cached volumes This allows for logic inside FillVolumeConfig to alter the default settings for new volumes and these then be used for the comparison with the previous cached image volumes, rather than only considering the pool config directly. This is needed for ZFS because zfs.block_mode can be enabled on the pool, but it shouldn't be used for comparison with VM image volumes because its not relevant for VM image volumes. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…ettings for VM volumes in FillVolumeConfig As these are not used. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
monstermunchkin
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of this issue was that filesystem block volume related settings were incorrectly being stored for ZFS VM block volumes. This PR changes that so that only filesystem volumes using ZFS block mode have the volume block settings stored.
Fixes #12067
Closes #12075