Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxddoc: fix quotes issues #12093

Merged
merged 1 commit into from
Aug 1, 2023
Merged

lxddoc: fix quotes issues #12093

merged 1 commit into from
Aug 1, 2023

Conversation

gabrielmougard
Copy link
Contributor

@gabrielmougard gabrielmougard commented Jul 31, 2023 •
edited
Loading

The generated .txt docuement used for templating option tables needs to have its values enclosed in double quotes as mentionned here #12047 (comment)

@gabrielmougard
lxddoc: unmarshal yaml + double-quotes processing
f8426ec 
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
@gabrielmougard gabrielmougard mentioned this pull request Jul 31, 2023
Closed
@tomponline tomponline requested a review from ru-fu July 31, 2023 18:57
ru-fu
ru-fu approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@ru-fu ru-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this with the content from #12047 now, and there aren't any build breaks anymore. :)

Thanks!

@tomponline tomponline merged commit 63fc35f into canonical:main Aug 1, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ru-fu ru-fu ru-fu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielmougard @ru-fu @tomponline