Allow recovery of empty storage pools #12108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MusicDin
force-pushed
the
fix/recover-empty-storage-pool
branch
2 times, most recently
from
2f2a976
to
1b37a1c
Compare
|
Hey @MusicDin please could you rebase this |
MusicDin
force-pushed
the
fix/recover-empty-storage-pool
branch
from
1b37a1c
to
986b295
Compare
Signed-off-by: Din Music <din.music@canonical.com>
Signed-off-by: Din Music <din.music@canonical.com>
Signed-off-by: Din Music <din.music@canonical.com>
MusicDin
force-pushed
the
fix/recover-empty-storage-pool
branch
from
986b295
to
5083d3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, empty storage pools cannot be recovered, because the missing storage pool DB entries are restored during the recovery only if the unknown volumes are detected within the storage pool.
Not being able to recover empty storage pools, prevents the creation of a new storage pool with the same.
This PR changes the recovery process to first recover the missing storage pool DB entries and then the unknown volumes.