Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loki: Add hostname as instance label value #12305

Merged

Conversation

monstermunchkin
Copy link
Contributor

Fixes #12290

Signed-off-by: Thomas Hipp thomas.hipp@canonical.com

lxd/loki/loki.go Outdated Show resolved Hide resolved
simondeziel
simondeziel previously approved these changes Sep 22, 2023
Fixes canonical#12290

Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Copy link
Member

@simondeziel simondeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@monstermunchkin
Copy link
Contributor Author

Doc linkcheck failures are unrelated:

404 Client Error: Not Found for url: https://documentation.ubuntu.com/lxd/en/latest/doc-cheat-sheet/

@tomponline tomponline merged commit b3e17a9 into canonical:main Sep 24, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loki logs should include an instance label indicating which LXD server generated the event
3 participants