lxd-agent: Adds an operation wait endpoint to fix VM exec operations #12372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markylaing
requested review from
monstermunchkin,
simondeziel,
masnax,
gabrielmougard and
MusicDin
After recent changes to the client in canonical#12349, when calling ExecInstance we wait for the operation to complete by directly calling the operation wait endpoint instead of listening for the event. When calling exec on a VM, the client is used to connect with the LXD agent via vsock. This was failing with a 404 because the endpoint didn't exist. Signed-off-by: Mark Laing <mark.laing@canonical.com>
markylaing
force-pushed
the
agent-operation-wait
branch
from
21a28fd
to
604ab63
Compare
tomponline
approved these changes
Oct 12, 2023
tomponline
changed the title
tomponline
changed the title
MusicDin
approved these changes
Oct 12, 2023
monstermunchkin
approved these changes
Oct 12, 2023
simondeziel
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After recent changes to the client in #12349, when calling ExecInstance we wait for the operation to complete by directly calling the operation wait endpoint instead of listening for the event.
When calling exec on a VM, the client is used to connect with the LXD agent via vsock. This was failing with a 404 because the endpoint didn't exist.