gomod: Switch UUID package #12471
Merged
gomod: Switch UUID package #12471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This effectively removes github.com/pborman/uuid from the list of dependencies and moves github.com/google/uuid to be a direct dependency. It's already included as an indirect dependency from other packages. The package github.com/pborman/uuid leverages github.com/google/uuid itself. See the projects README for more details. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
…uuid Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
…/uuid Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
MarshalBinary returns an error which needs to be handled downstream. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
|
What is the reason for doing this? |
We can get rid of a dependency and use a package that seems to be actively developed (based on recent commits). |
I didn't realise that the pborman package wasn't being developed! Yes this is much preferred. I'd like to make this change in LXD Cloud too. |
roosterfish
commented
Oct 26, 2023
tomponline
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively removes
github.com/pborman/uuidfrom the list of dependencies and movesgithub.com/google/uuidto be a direct dependency. It's already included as an indirect dependency from other packages.The package
github.com/pborman/uuidleveragesgithub.com/google/uuiditself. See the projects README for more details.