Go: Bump minimum version to 1.20 #12506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
tomponline
force-pushed
the
tp-go1.20
branch
5 times, most recently
from
5a43a00
to
02dd4f5
Compare
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com> Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
rand.Seed has been deprecated since Go 1.20 Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Otherwise it logs a line for every non-Go file! Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
tomponline
changed the title
x509.ParseCRL() has been deprecated since Go 1.19 Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
pkix.TBSCertificateList has been deprecated since Go 1.19 and replaced by x509.RevocationList. Signed-off-by: Simon Deziel <simon.deziel@canonical.com> Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
roosterfish
approved these changes
Nov 5, 2023
MusicDin
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the highest version we can go to at the moment due to readthedocs.
But that is actually fine as it allows us to update our dependencies to get latest security fixes (ala grpc), and still maintain compatibility with more Go versions.