lxd_metadata: annotate remaining network properties #13355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Documentation
|
Heads up @ru-fu - the "Documentation" label was applied to this issue. |
ru-fu
reviewed
Apr 23, 2024
gabrielmougard
force-pushed
the
feat/annotate-network-properties
branch
from
fdecda3
to
fc77c68
Compare
|
@ru-fu updated |
ru-fu
reviewed
Apr 29, 2024
|
lxd metadata permissions issues fixed in 2bda09e |
gabrielmougard
force-pushed
the
feat/annotate-network-properties
branch
from
fc77c68
to
4d5081b
Compare
|
@ru-fu udpated |
ru-fu
reviewed
May 2, 2024
|
#13379 has now been merged - so when bringing in those changes, #13379 (comment) and #13379 (comment) must be updated. |
|
Needs a rebase please |
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com> Co-authored-by: Ruth Fuchss <ruth.fuchss@canonical.com>
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com> Co-authored-by: Ruth Fuchss <ruth.fuchss@canonical.com>
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com> Co-authored-by: Ruth Fuchss <ruth.fuchss@canonical.com>
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com> Co-authored-by: Ruth Fuchss <ruth.fuchss@canonical.com>
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com> Co-authored-by: Ruth Fuchss <ruth.fuchss@canonical.com>
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
gabrielmougard
force-pushed
the
feat/annotate-network-properties
branch
from
4d5081b
to
84cc9d8
Compare
|
@ru-fu @tomponline updated |
tomponline
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket: https://warthogs.atlassian.net/jira/software/c/projects/LXD/boards/54?assignee=63d9eb6128cddcc70770aff1&selectedIssue=LXD-918