-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grafana/Loki fixes from Incus #13427
Merged
tomponline
merged 9 commits into
canonical:main
from
simondeziel:grafana-loki-fixes-from-incus
May 3, 2024
Merged
Grafana/Loki fixes from Incus #13427
tomponline
merged 9 commits into
canonical:main
from
simondeziel:grafana-loki-fixes-from-incus
May 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heads up @ru-fu - the "Documentation" label was applied to this issue. |
Signed-off-by: Stéphane Graber <stgraber@stgraber.org> (cherry picked from commit d159ee67b046b94da046370ae982981468d4d9d3) Signed-off-by: Simon Deziel <simon.deziel@canonical.com> License: Apache-2.0
simondeziel
force-pushed
the
grafana-loki-fixes-from-incus
branch
from
May 3, 2024 03:33
676e6bb
to
03ef17e
Compare
ru-fu
reviewed
May 3, 2024
Signed-off-by: Stéphane Graber <stgraber@stgraber.org> (cherry picked from commit e80628d69d596047b4904b62fe52f8c620b12cf4) Signed-off-by: Simon Deziel <simon.deziel@canonical.com> License: Apache-2.0
Signed-off-by: Stéphane Graber <stgraber@stgraber.org> (cherry picked from commit e80628d69d596047b4904b62fe52f8c620b12cf4) Signed-off-by: Simon Deziel <simon.deziel@canonical.com> License: Apache-2.0
It shows the old ID (15726) and the right one (19131) is already in `doc/images/grafana_dashboard_id.png`. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Closes canonical#13165 and lxc/incus#761 Signed-off-by: Stéphane Graber <stgraber@stgraber.org> (cherry picked from commit 9d31814a93669e38d6b6a2a8215175f546f582d1) Signed-off-by: Simon Deziel <simon.deziel@canonical.com> License: Apache-2.0
…ystems Closes lxc/incus#762 Signed-off-by: Stéphane Graber <stgraber@stgraber.org> (cherry picked from commit f7acfd818d3538c9908438bb92e64ec669dbd165) Signed-off-by: Simon Deziel <simon.deziel@canonical.com> License: Apache-2.0
Signed-off-by: Stéphane Graber <stgraber@stgraber.org> (cherry picked from commit 08267a0eabf5492b607277165e75f786eb5233d0) Signed-off-by: Simon Deziel <simon.deziel@canonical.com> License: Apache-2.0
Signed-off-by: Stéphane Graber <stgraber@stgraber.org> (cherry picked from commit 7a77f39b2e62b21151da614e18df16e4e82ffcae) Signed-off-by: Simon Deziel <simon.deziel@canonical.com> License: Apache-2.0
Signed-off-by: Stéphane Graber <stgraber@stgraber.org> (cherry picked from commit b2f1f91b09e3c3d4b46673880a2044f8ff2e6e87) Signed-off-by: Simon Deziel <simon.deziel@canonical.com> License: Apache-2.0
simondeziel
force-pushed
the
grafana-loki-fixes-from-incus
branch
from
May 3, 2024 13:40
03ef17e
to
b1fd32c
Compare
tomponline
approved these changes
May 3, 2024
https://grafana.com/grafana/dashboards/19131-lxd/ updated with revision 5 of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From lxc/incus#764