Seccomp: Tighten container capability checks a bit to align with kernel behaviour #13458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihalicyn
force-pushed
the
additional_cap_checks
branch
2 times, most recently
from
6bf62b7
to
837d73d
Compare
simondeziel
previously approved these changes
May 8, 2024
tomponline
reviewed
May 8, 2024
tomponline
reviewed
May 8, 2024
tomponline
reviewed
May 8, 2024
tomponline
reviewed
May 8, 2024
tomponline
reviewed
May 8, 2024
tomponline
reviewed
May 8, 2024
tomponline
reviewed
May 8, 2024
tomponline
changed the title
|
Thanks @mihalicyn ! |
mihalicyn
force-pushed
the
additional_cap_checks
branch
from
837d73d
to
570b873
Compare
Let's tighten capability checks in mknod interception code to align this with what we have in the kernel. So, if mknod interception is enabled then only user with CAP_MKNOD in the container's initial user namespace can use it. Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
mihalicyn
force-pushed
the
additional_cap_checks
branch
from
570b873
to
b7dc46b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's tighten capability checks in mknod interception code to align this with what we have in the kernel. So, if mknod interception is enabled then only user with CAP_MKNOD in the container's initial user namespace can use it.