Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused prameters #13504

Merged
merged 72 commits into from
Jun 4, 2024
Merged

Remove unused prameters #13504

merged 72 commits into from
Jun 4, 2024

Commits on Jun 3, 2024

  1. lxd/network/driver_bridge: check the right error code when killing dn… 

    …smask

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    5e3628f View commit details
    Browse the repository at this point in the history

  2. lxd/network/driver_bridge: check the right error code when killing fo… 

    …rkdns

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    af6df85 View commit details
    Browse the repository at this point in the history

  3. lxd/network/driver_bridge: remove redundant error checking 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    a1e6934 View commit details
    Browse the repository at this point in the history

  4. lxd/network/common: remove unused clientType param for delete() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    3561453 View commit details
    Browse the repository at this point in the history

  5. lxd/network/utils: remove unused s param for usedByProfileDevices() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    7504573 View commit details
    Browse the repository at this point in the history

  6. lxc/info: remove unused remotes param for instanceInfo() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    1b7a43e View commit details
    Browse the repository at this point in the history

  7. lxd/cluster: remove unused cert param for loadInfo() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    5177947 View commit details
    Browse the repository at this point in the history

  8. lxd/storage/filesystem/fs: check for error when detecting btrfs 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    126dece View commit details
    Browse the repository at this point in the history

  9. lxc/list: remove unused conf param to listInstances() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    904ebb6 View commit details
    Browse the repository at this point in the history

  10. lxc/file: remove redundant error checking 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    7703bec View commit details
    Browse the repository at this point in the history

  11. lxc/list: remove unused cInfo param to matchByNet() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    b89aa62 View commit details
    Browse the repository at this point in the history

  12. lxc-to-lxd: remove unused op param to transferRootfs() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    e3dee81 View commit details
    Browse the repository at this point in the history

  13. lxd-agent: remove unused debug param 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    5f0cb0c View commit details
    Browse the repository at this point in the history

  14. lxd-agent: remove unused daemon param to get*Metrics() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    50aa824 View commit details
    Browse the repository at this point in the history

  15. lxd/apparmor: remove unused sysOS param to *Profile() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    00eca4d View commit details
    Browse the repository at this point in the history

  16. lxd/apparmor/qemuimg: fix error check when creating subprocess 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    9170486 View commit details
    Browse the repository at this point in the history

  17. lxd/auth/openfga: check error only once 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    0c1d20e View commit details
    Browse the repository at this point in the history

  18. lxd/db/cluster/update: remove redundant error check 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    fa0f09c View commit details
    Browse the repository at this point in the history

  19. lxd/db/generate/file/write: remove unused imports param to resetInter… 

    …face()

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    16c49ac View commit details
    Browse the repository at this point in the history

  20. lxd/db/generate/db/stmt: remove unused filters param to register() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    ccba49c View commit details
    Browse the repository at this point in the history

  21. lxd/db/generate/README: fix some markdownlint warnings 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    7df7ccb View commit details
    Browse the repository at this point in the history

  22. lxd/db/query/slices: remove unused typeName param to scanSingleColumn() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    11f58a3 View commit details
    Browse the repository at this point in the history

  23. lxd/db/networks: remove unused tx param to getNetworkConfig() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    67c5cd3 View commit details
    Browse the repository at this point in the history

  24. lxd/db/storage_pools: remove unused tx param to getStoragePoolConfig() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    3bfaf4f View commit details
    Browse the repository at this point in the history

  25. lxd/db/storage_pools: remove duplicated error checking in getStorageP… 

    …ool()

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    b663158 View commit details
    Browse the repository at this point in the history

  26. lxd/device/device_utils_network: remove tautological nil check 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    476c58d View commit details
    Browse the repository at this point in the history

  27. lxd/device/nic_ovn: remove unused uplink param to setupHostNIC() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    ad3d40e View commit details
    Browse the repository at this point in the history

  28. lxd/device/proxy: check the right error code when killing forkproxy 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    b25900b View commit details
    Browse the repository at this point in the history

  29. lxd/dns/debug: remove unused zone param to debug() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    ec46258 View commit details
    Browse the repository at this point in the history

  30. lxd/firewall/firewall_load: remove tautological check and remove dead… 

    … code

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    a88f546 View commit details
    Browse the repository at this point in the history

  31. lxd/instance/drivers/qemu: avoid dereferencing nil 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    60df958 View commit details
    Browse the repository at this point in the history

  32. lxd: remove unused forcecheck param to storageStartup() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    9d893f8 View commit details
    Browse the repository at this point in the history

  33. lxd/instance/drivers/qemu_metrics: remove unused monitor param to get… 

    …QemuMemoryMetrics()

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    ff87f2d View commit details
    Browse the repository at this point in the history

  34. lxd/daemon_storage: remove unused storageType param to mount()/umount() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    9cf116a View commit details
    Browse the repository at this point in the history

  35. lxd/instance/drivers/common: remove unused stateful param to validate… 

    …Startup()

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    e227345 View commit details
    Browse the repository at this point in the history

  36. lxd/instance/drivers/qemu: remove unused configCopy param to deviceAt… 

    …tachNIC()

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    22a8824 View commit details
    Browse the repository at this point in the history

  37. lxd/instance/drivers/qemu: remove unused configCopy and mount params … 

    …to deviceAttachPath()

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    4680c7a View commit details
    Browse the repository at this point in the history

  38. lxd/instance/drivers/qemu: remove unused deviceName and configCopy pa… 

    …rams to deviceAttachBlockDevice()

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    9935d75 View commit details
    Browse the repository at this point in the history

  39. lxd/instance/drivers/qemu: remove unused rawConfig param to deviceDet… 

    …achPath()

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    a2889e1 View commit details
    Browse the repository at this point in the history

  40. lxd/instance/drivers/qemu: remove unused rawConfig param to deviceDet… 

    …achBlockDevice()

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    5d3464a View commit details
    Browse the repository at this point in the history

  41. lxd/instance_file: remove unused s and r params to instanceFileHead() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    7230c67 View commit details
    Browse the repository at this point in the history

  42. lxd/instance_file: remove unused r param to instanceFileDelete() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    34e8dbd View commit details
    Browse the repository at this point in the history

  43. lxd/main_forkproxy: remove unused timeout param to genericRelay() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    863dce9 View commit details
    Browse the repository at this point in the history

  44. lxd/storage/drivers/cephobject: remove unused bucket param to radosgw… 

    …adminBucketSetQuota()

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    4f80aed View commit details
    Browse the repository at this point in the history

  45. gomod: drop unused mods: checkpoint-restore/go-criu/v7 and juju/gomaa… 

    …sapi/v2

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    70f248b View commit details
    Browse the repository at this point in the history

  46. lxd/instance/drivers/driver_qemu: Fix indentation. 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    08ef8bf View commit details
    Browse the repository at this point in the history

  47. lxc/file: simplify loop by continuing early 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    b4ed88b View commit details
    Browse the repository at this point in the history

  48. lxc/list: remove duplicated comment marker 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    44eaa07 View commit details
    Browse the repository at this point in the history

  49. lxc/list: return early in loop 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    ca4d4e2 View commit details
    Browse the repository at this point in the history

  50. lxd/apparmor/dnsmasq: omit unneeded type declaration 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    cf3fd80 View commit details
    Browse the repository at this point in the history

  51. lxd/apparmor/forkdns: omit unneeded type declaration 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    567e83f View commit details
    Browse the repository at this point in the history

  52. lxd/apparmor/forkproxy: omit unneeded type declaration 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    a1fdd01 View commit details
    Browse the repository at this point in the history

  53. lxd/apparmor/qemuimg: omit unneeded type declaration 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    e9a3343 View commit details
    Browse the repository at this point in the history

  54. lxd/apparmor/qemuimg: add space after comment marker 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    a0bd893 View commit details
    Browse the repository at this point in the history

  55. lxc-to-lxd/main_migrate: return early in loop 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    b4c1bb3 View commit details
    Browse the repository at this point in the history

  56. lxd/main_forkproxy: UDP should be capitalized 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    e7085bb View commit details
    Browse the repository at this point in the history

  57. lxd/storage/drivers/cephobject_buckets: fix comment for CreateBucketK… 

    …ey()

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    0598fb5 View commit details
    Browse the repository at this point in the history

  58. lxd/instance_file: remove uneeded else clauses 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    af3c009 View commit details
    Browse the repository at this point in the history

  59. lxc/list: unexport architectureColumnData() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    00f8620 View commit details
    Browse the repository at this point in the history

  60. lxc/list: unexport storagePoolColumnData() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    ac68355 View commit details
    Browse the repository at this point in the history

  61. lxc/list: unexport createdColumnData() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    ee3dd78 View commit details
    Browse the repository at this point in the history

  62. lxc/list: unexport numberOfProcessesColumnData() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    5017daa View commit details
    Browse the repository at this point in the history

  63. lxc/list: unexport profilesColumnData() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    cf461a1 View commit details
    Browse the repository at this point in the history

  64. lxc/list: unexport lastUsedColumnData() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    db25e75 View commit details
    Browse the repository at this point in the history

  65. lxc/list: add comments to exported functions 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    aedfab0 View commit details
    Browse the repository at this point in the history

  66. lxc/file: add comments to exported functions 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    1e2a4cf View commit details
    Browse the repository at this point in the history

  67. lxc/info: add comments to exported functions 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    a689b21 View commit details
    Browse the repository at this point in the history

  68. lxd/main_forkproxy: add comments to exported functions 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    87287ef View commit details
    Browse the repository at this point in the history

  69. lxc-to-lxd/main_migrate: add comments to exported functions 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    333ef64 View commit details
    Browse the repository at this point in the history

  70. lxd-agent: add comments to exported functions 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    08de213 View commit details
    Browse the repository at this point in the history

  71. lxd/apparmor/qemuimg: add comment to exported function 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    2dea0ef View commit details
    Browse the repository at this point in the history

  72. lxd/device/device_utils_network: add space after comment marker 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel
    simondeziel committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    507313d View commit details
    Browse the repository at this point in the history