Automatic IP allocation follow up #13540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markylaing
commented
Jun 4, 2024
markylaing
force-pushed
the
ip-allocation-follow-up
branch
from
6235b22
to
fced8de
Compare
|
Marking as draft until #13543 is merged. |
markylaing
force-pushed
the
ip-allocation-follow-up
branch
from
fced8de
to
37f93b9
Compare
Signed-off-by: Mark Laing <mark.laing@canonical.com>
markylaing
force-pushed
the
ip-allocation-follow-up
branch
from
37f93b9
to
5fd67f9
Compare
The caller can now return a boolean to indicate if the IP address is valid or not. The error value is used to indicate if an error occurred during validation. Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
…from ovn. This keeps the code path similar between drivers for easier context switching. Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
When creating a network forward, the `checkAddressNotInUse` function was using the value of `listenAddressNet` directly (it is available in scope), and not the given `net.IP` argument. For automatic IP allocation, `listenAddressNet` will have been unspecified. This meant that allocating an IP for a network forward was not correctly validating the randomly assigned IP addresses and would have led to a bug. Signed-off-by: Mark Laing <mark.laing@canonical.com>
markylaing
force-pushed
the
ip-allocation-follow-up
branch
from
5fd67f9
to
e3087ad
Compare
|
@tomponline I've rebased and fixed a couple of things I found on revisiting it. The last commit of this PR isn't from a comment on #13379 - it's a bugfix. I just found it today (can open a separate PR if you'd prefer but kept it here since it's all related) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses remaining discussions in #13379.
Depends on #13543
Closes #13422