lxd/apparmor/lxc: reorganize mount options rules for priv containers #13565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noticed by Aleks we have duplicated mount options rules for unprivileged containers. The apparmor parser does rule deduplication so it doesn't really matter. However, the "limited" part of the "Allow limited modification of mount propagation" comment was misleading. As such, it's best to avoid the duplicated rules and make it clear that privileged containers have limited permissions while unprivileged ones have unlimited permissions for mount options. Fixes "lxd/apparmor/lxc: remove dup mount options rules" commit 2e55b23. Signed-off-by: Simon Deziel <simon.deziel@canonical.com> lxd/apparmor/lxc: reorganize mount options rules for priv containers Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
tomponline
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noticed by Aleks we have duplicated mount options rules for unprivileged containers.
The apparmor parser does rule deduplication so it doesn't really matter. However, the "limited" part of the "Allow limited modification of mount propagation" comment was misleading. As such, it's best to avoid the duplicated rules and make it clear that privileged containers have limited permissions while unprivileged ones have unlimited permissions for mount options.
Fixes "lxd/apparmor/lxc: remove dup mount options rules" commit 2e55b23.
lxd/apparmor/lxc: reorganize mount options rules for priv containers