shared/cert: Set Not Before in self-signed cert to now-1minute #13606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the following made up conditions: * a remote LXD server `s` has its time set to `13:42:00` * a client `foo` has its time set to `13:42:15` (15s in advance of `s`) * a remote add token is created for `foo` * `foo` uses the token and since it's brand new, it creates its self-signed cert and save its current time in the Not Before field: 13:42:15 * `s` inspect `foo`'s cert and refuses it because it is in future In the above situation, the fact that a token was used make it easier to trip on a time delta between the client and server because the cert is create on the spot before being sent to the server. Having the client set a Not Before time slightly in the past should make it easier to interact with remote servers that are slightly "in the past". Fixes canonical#13388. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
simondeziel
added a commit
to simondeziel/lxd-ci
that referenced
this pull request
Jun 14, 2024
In theory, canonical/lxd#13606 should be a better way to fix this. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the following made up conditions:
shas its time set to13:42:00foohas its time set to13:42:15(15s in advance ofs)foofoouses the token and since it's brand new, it creates its self-signed cert and save its current time in the Not Before field: 13:42:15sinspectfoo's cert and refuses it because it is in futureIn the above situation, the fact that a token was used make it easier to trip on a time delta between the client and server because the cert is create on the spot before being sent to the server.
Having the client set a Not Before time slightly in the past should make it easier to interact with remote servers that are slightly "in the past".
Fixes #13388.