Disable VM CPU auto pinning (stable-5.21) #13670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
This reverts commit 9eb8308. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
simondeziel
reviewed
Jun 26, 2024
Comment on lines
+7489
to
+7490
| cpuCoreIndex, _ := strconv.Atoi(set[i]) | ||
| affinitySet.Set(cpuCoreIndex) |
There was a problem hiding this comment.
A tiny nitpick, maybe?:
Suggested change
| cpuCoreIndex, _ := strconv.Atoi(set[i]) | |
| affinitySet.Set(cpuCoreIndex) | |
| cpuCoreIndex, _ := strconv.ParseUint(set[i], 10, 64) | |
| affinitySet.Set(int(cpuCoreIndex)) |
There was a problem hiding this comment.
Please change that in main and then it can be back ported
simondeziel
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores the previously reverted
SetAffinityimplementation for qemu driver so we can easily cherry-pick fixes from main in the future for this.And instead adds logic to prevent auto pinning for VMs in the
deviceEventListenerwhich also stops the logging of thelevel=debug msg="Scheduler: virtual-machine v1 changed: re-balancing"message.We can take this out later once needed.