lxc: Add validation for non-empty remote address #13694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@boltmark please can you sign your commits, see https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification |
Signed-off-by: Mark Bolton <mark.bolton@canonical.com>
Signed-off-by: Mark Bolton <mark.bolton@canonical.com>
boltmark
force-pushed
the
fix-empty-remote-target-panic
branch
from
8402995
to
6a57144
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to ensure that the provided remote address is not empty when adding a new remote server. In place of the previous panic, we now return an error message to the user.
Closes #13682