Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance: Re-generate missing container lxc.conf during Exec (from Incus) #13697

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

tomponline
Copy link
Member

@tomponline tomponline commented Jul 2, 2024

(cherry picked from commit 36b995ef876e04ec4f54e1a8f82e178980276392)

License: Apache-2.0

Fixes #12084

@tomponline tomponline self-assigned this Jul 2, 2024
@tomponline tomponline changed the title Instance: Re-generate container lxc.conf during Exec (from Incus) Instance: Re-generate missing container lxc.conf during Exec (from Incus) Jul 2, 2024
@tomponline tomponline marked this pull request as ready for review July 2, 2024 12:56
Copy link
Member

@simondeziel simondeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a dup signed-off tag in the cherry-picked commit.

stgraber and others added 2 commits July 2, 2024 14:08
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
(cherry picked from commit 36b995ef876e04ec4f54e1a8f82e178980276392)
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
License: Apache-2.0
…-lxc

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
@tomponline
Copy link
Member Author

You have a dup signed-off tag in the cherry-picked commit.

Fixed, surprised git doesn't de-dupe those.

@tomponline tomponline merged commit f116186 into canonical:main Jul 2, 2024
28 checks passed
@tomponline tomponline deleted the tp-lxc-restore-conf branch July 2, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Failed to retrieve PID of executing child process
4 participants