Device: Fix crash when none type device is added to running instance
#13775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urn run config when being live updated Fixes canonical#13774 Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,21 @@ | |||
| test_container_devices_none() { | |||
Check failure
Code scanning / shellcheck
SC2148 Error test
There was a problem hiding this comment.
@simondeziel do you know why we are getting this, but not on the existing files?
There was a problem hiding this comment.
It's something I'm trying to address in #13776
Useful to catch missing runConf != nil issues. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
|
@simondeziel would u mind approving this so i can merge n Cherry pick the fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13774