Storage: Fix import of instance snapshots with underscores in their names #13899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt in CreateInstanceFromBackup Fixes canonical#13879 Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…dName Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…pshot names Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
tomponline
requested review from
kadinsayani,
markylaing,
MusicDin and
simondeziel
kadinsayani
approved these changes
Aug 9, 2024
simondeziel
reviewed
Aug 9, 2024
| @@ -658,7 +658,11 @@ func ValidName(instanceName string, isSnapshot bool) error { | |||
| return fmt.Errorf("Invalid instance name %q: %w", parentName, err) | |||
| } | |||
|
|
|||
| // Snapshot part is more flexible, but doesn't allow space or / character. | |||
| // Snapshot part is more flexible, but doesn't allow "..", space or / characters. | |||
There was a problem hiding this comment.
Should we also reject *?
$ lxc snapshot c1 '.*'
Error: Create instance snapshot: Failed to run: zfs snapshot -r default/containers/c1@snapshot-.*: exit status 1 (cannot create snapshot 'default/containers/c1@snapshot-.*': invalid character '*' in name
no snapshots were created)And also @ and # which have special meaning in ZFS at least.
There was a problem hiding this comment.
yeah maybe - although this might break users who've used snapshots with those chars in on non-zfs drivers.
tomponline
added a commit
to tomponline/lxd-pkg-snap
that referenced
this pull request
Aug 20, 2024
From canonical/lxd#13899 Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
tomponline
added a commit
to canonical/lxd-pkg-snap
that referenced
this pull request
Aug 20, 2024
- Fix Dell Powerflex migrations from canonical/lxd#13934 - Fix snap preseed support from #532 - Fix snapshot importing from canonical/lxd#13899
tomponline
added a commit
to tomponline/lxd-pkg-snap
that referenced
this pull request
Aug 20, 2024
- Fix for Oracular unprivileged containers from canonical/lxd#13820 - Fix snapshot importing from canonical/lxd#13899 - Fix Dell Powerflex migrations from canonical/lxd#13934 Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
tomponline
added a commit
to canonical/lxd-pkg-snap
that referenced
this pull request
Aug 20, 2024
- Fix Dell Powerflex migrations from canonical/lxd#13934 - Fix snap preseed support from #532 - Fix snapshot importing from canonical/lxd#13899 - Vendor apparmor and cherry-pick Oracular container fixes from #534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13879
Closes #13897