-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cluster recovery #340
Cluster recovery #340
Conversation
b1cf983
to
208f89b
Compare
208f89b
to
44ef03b
Compare
f522401
to
f609788
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the doc update looks good! Some general comments and some nitpicks, of course. 😉
4308a20
to
ae1e170
Compare
09cfbb2
to
c2ad2f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! All happy with the docs now. 🚀
Test failure looks the same as we're seeing on other PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a couple nits
For modifying yaml (used in recovery tests) Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Fixes canonical#291 Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
c2ad2f6
to
f8c519b
Compare
f8c519b
to
16389c7
Compare
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
16389c7
to
edcca3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Implements cluster recovery with the same set of changes described in canonical/microcluster#149
basic
, andbasic
already takes ~1hr to run. Not sure what is preferred here.Fixes #291
LXD-1118