Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster recovery #340

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Cluster recovery #340

merged 5 commits into from
Jul 12, 2024

Conversation

MggMuggins
Copy link
Contributor

@MggMuggins MggMuggins commented Jul 5, 2024

Implements cluster recovery with the same set of changes described in canonical/microcluster#149

Fixes #291

LXD-1118

test/suites/recover.sh Fixed Show fixed Hide fixed
@MggMuggins MggMuggins force-pushed the cluster-recover branch 5 times, most recently from f522401 to f609788 Compare July 9, 2024 05:07
Copy link
Contributor

@ru-fu ru-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the doc update looks good! Some general comments and some nitpicks, of course. 😉

doc/how-to/recover.md Outdated Show resolved Hide resolved
doc/how-to/recover.md Show resolved Hide resolved
doc/how-to/recover.md Show resolved Hide resolved
doc/how-to/recover.md Outdated Show resolved Hide resolved
doc/how-to/recover.md Outdated Show resolved Hide resolved
doc/how-to/recover.md Outdated Show resolved Hide resolved
doc/how-to/recover.md Outdated Show resolved Hide resolved
doc/how-to/recover.md Outdated Show resolved Hide resolved
doc/how-to/recover.md Outdated Show resolved Hide resolved
doc/how-to/recover.md Outdated Show resolved Hide resolved
@MggMuggins MggMuggins force-pushed the cluster-recover branch 5 times, most recently from 4308a20 to ae1e170 Compare July 10, 2024 04:13
doc/how-to/recover.md Outdated Show resolved Hide resolved
@MggMuggins MggMuggins force-pushed the cluster-recover branch 2 times, most recently from 09cfbb2 to c2ad2f6 Compare July 10, 2024 14:55
ru-fu
ru-fu previously approved these changes Jul 10, 2024
Copy link
Contributor

@ru-fu ru-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! All happy with the docs now. 🚀

@MggMuggins
Copy link
Contributor Author

Test failure looks the same as we're seeing on other PRs

@MggMuggins MggMuggins marked this pull request as ready for review July 10, 2024 17:16
Copy link
Contributor

@masnax masnax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a couple nits

cmd/microcloud/cluster_members.go Outdated Show resolved Hide resolved
cmd/microcloud/cluster_members.go Outdated Show resolved Hide resolved
test/suites/recover.sh Outdated Show resolved Hide resolved
cmd/microcloud/cluster_members.go Show resolved Hide resolved
doc/how-to/recover.md Outdated Show resolved Hide resolved
For modifying yaml (used in recovery tests)

Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Fixes canonical#291

Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
doc/how-to/recover.md Outdated Show resolved Hide resolved
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Copy link
Contributor

@masnax masnax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@masnax masnax merged commit e8b6cef into canonical:main Jul 12, 2024
15 of 16 checks passed
@MggMuggins MggMuggins deleted the cluster-recover branch July 12, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add recovery option for quorum loss.
3 participants