Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: reorganize apps into servers and apps, rework the server fixture and add Miriway #110

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Mar 20, 2024

This adds a ServerCap flag to describe server capabilities and a servers(ServerCap) selector to aid with test parametrization.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 66.62%. Comparing base (6fae7c4) to head (13a2374).
Report is 8 commits behind head on main.

Files Patch % Lines
mir-ci/mir_ci/conftest.py 76.92% 3 Missing ⚠️
mir-ci/mir_ci/fixtures/__init__.py 81.25% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   65.19%   66.62%   +1.43%     
==========================================
  Files          14       16       +2     
  Lines         770      809      +39     
  Branches      103      112       +9     
==========================================
+ Hits          502      539      +37     
- Misses        243      245       +2     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Saviq Saviq force-pushed the add-miriway branch 3 times, most recently from 2ba1046 to 015bdcf Compare March 20, 2024 10:13
@Saviq Saviq marked this pull request as ready for review March 20, 2024 10:36
@Saviq Saviq requested a review from a team as a code owner March 20, 2024 10:36
@Saviq Saviq requested a review from mattkae March 20, 2024 10:36
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single question, but makes sense to me!

mir-ci/mir_ci/fixtures/servers.py Show resolved Hide resolved
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@mattkae mattkae added this pull request to the merge queue Mar 20, 2024
Merged via the queue into main with commit a52974d Mar 20, 2024
14 checks passed
@mattkae mattkae deleted the add-miriway branch March 20, 2024 14:43
Saviq added a commit to canonical/checkbox-mir that referenced this pull request Mar 21, 2024
Since we've moved files around (canonical/mir-ci#110), these broke. But
also found a simpler way to list tests.
Saviq pushed a commit that referenced this pull request Mar 29, 2024
tests: reorganize apps into servers and apps, rework the server fixture and add Miriway
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants