Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BasicScreenShooter should have a configurable GLConfig #3438

Closed
mattkae opened this issue Jun 21, 2024 · 1 comment · Fixed by #3444
Closed

BasicScreenShooter should have a configurable GLConfig #3438

mattkae opened this issue Jun 21, 2024 · 1 comment · Fixed by #3444
Labels
bug

Comments

@mattkae
Copy link
Contributor

mattkae commented Jun 21, 2024

Requirements
@mattkae mattkae added the bug label Jun 21, 2024
@mattkae mattkae mentioned this issue Jun 21, 2024
Open
@mattkae
Copy link
Contributor Author

mattkae commented Jun 22, 2024

Ah, the other issue here is that CPUCopyOutputSurface can not (?) provide depth and stencil bits.

@mattkae mattkae mentioned this issue Jun 25, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 1, 2024
@AlanGriffiths
bugfix: screenshots now respect the GLConfig and contain a depth + …
317060e 
…stencil buffer when one is required (#3444)

fixes #3438

## What's new?
- `BasicScreenShooter` now respects the `GLConfig`
- When depth and stencil bits are provided, we create a render buffer
for them

I was unable to make separate stencil/depth buffers worked, but it is
_apparently_ recommended that they are combined. I don't know if this
will have any major issues...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@mattkae