Build mir-libs for both core22 and core24 #3364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3364 +/- ##
==========================================
+ Coverage 77.34% 77.50% +0.16%
==========================================
Files 1065 1065
Lines 67869 67896 +27
==========================================
+ Hits 52490 52625 +135
+ Misses 15379 15271 -108 ☔ View full report in Codecov by Sentry. |
AlanGriffiths
force-pushed
the
mir-libs-for-22-and-24
branch
from
8dfa011
to
fd11e05
Compare
AlanGriffiths
force-pushed
the
mir-libs-for-22-and-24
branch
from
fd11e05
to
5ac76e4
Compare
|
The arm{hf,64} builds are failing elsewhere too. For example: https://github.com/canonical/mir/actions/runs/8880657717/job/24381211641?pr=3346 |
AlanGriffiths
force-pushed
the
mir-libs-for-22-and-24
branch
from
aa80e80
to
74fe517
Compare
AlanGriffiths
force-pushed
the
mir-libs-for-22-and-24
branch
2 times, most recently
from
8550b62
to
e46a69a
Compare
AlanGriffiths
force-pushed
the
mir-libs-for-22-and-24
branch
from
e46a69a
to
0066962
Compare
mattkae
requested changes
May 3, 2024
mattkae
approved these changes
May 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced May 6, 2024
github-merge-queue bot
pushed a commit
to canonical/mir-ci
that referenced
this pull request
May 7, 2024
This should only land after: - [x] canonical/confined-shell-wip#37 - [x] canonical/ubuntu-frame#177 - [x] Miriway/Miriway#94 - [x] canonical/ubuntu-frame-osk#73 - [x] canonical/ubuntu-frame-vnc#20 - [x] canonical/mir#3364
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows snaps (such as Miriway) to build on either base, and to transition to core24 at their own pace