feature: resolving snap desktop files using app armor as the primary source

[mattkae]

What's new?

• AppArmor is now the primary source of snap desktop files in the DesktopFileManager

[mattkae]

Whoops, broke the tests. Will fix em soon...

[Saviq]

You'll need to add a libapparmor build dependency to debian/control, and to snap/snapcraft.yaml.

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.23%. Comparing base (b5486c1) to head (19ce37f).
Report is 424 commits behind head on main.

Files with missing lines	Patch %	Lines
...c/server/frontend_wayland/desktop_file_manager.cpp	80.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3426      +/-   ##
==========================================
- Coverage   77.25%   77.23%   -0.03%     
==========================================
  Files        1071     1061      -10     
  Lines       68363    68069     -294     
==========================================
- Hits        52811    52570     -241     
+ Misses      15552    15499      -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mattkae]

@Saviq What should I do about the apparmor dependency on Fedora and Alpine? 🤔 Should that be an optional dependency?

[Saviq]

@Saviq What should I do about the apparmor dependency on Fedora and Alpine? 🤔 Should that be an optional dependency?

If they're not there, yeah.

[Saviq]

@mattkae Alpine does have it, BTW:

https://pkgs.alpinelinux.org/packages?name=apparmor

[mattkae]

@mattkae Alpine does have it, BTW:

https://pkgs.alpinelinux.org/packages?name=apparmor

Do you know if I'll need something else there too? https://github.com/canonical/mir/actions/runs/9552401270/job/26328915493?pr=3426

[Saviq]

Do you know if I'll need something else there too? https://github.com/canonical/mir/actions/runs/9552401270/job/26328915493?pr=3426

Yeah, you need to install it! :D

mir/spread/build/alpine/task.yaml

Lines 6 to 34 in 31ef078

	apk add \
	boost-dev \
	ccache \
	cmake \
	coreutils \
	elogind \
	eudev-dev \
	freetype-dev \
	g++ \
	glib-dev \
	glm-dev \
	grep \
	gtest-dev \
	libepoxy-dev \
	libevdev-dev \
	libinput-dev \
	libxcursor-dev \
	libxkbcommon-dev \
	libxml++-2.6-dev \
	lttng-ust-dev \
	lttng-ust-tools \
	make \
	mesa-dev \
	nettle-dev \
	py3-dbusmock \
	py3-pillow \
	umockdev-dev \
	wayland-dev \
	yaml-cpp-dev

[mattkae]

mir/spread/build/alpine/task.yaml

I have indeed added it, to no avail: https://github.com/canonical/mir/actions/runs/9566199163/job/26370892700?pr=3426 😢 Is there something else that I'm missing here?

[Saviq]

Is there something else that I'm missing here?

Don't go around blind :)

spread -debug lxd:alpine-3.19:spread/build/alpine:amd64

The package you're after is libapparmor:

https://pkgs.alpinelinux.org/packages?name=libapparmor

[mattkae]

_lib_apparmor

That is what I have ;) 918237e#diff-5f6d75408d28a1d92efc5968e0b1a34ee3c512d14427c514e56cd0b23290f52d

[RAOF]

Looks sensible, but the build system parts could be cleaned up.

[Saviq]

Looks legit to me.

[Saviq]

Yeah!