Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multipass GUI notification gets annoying after a while #2975

Closed
ricab opened this issue Mar 17, 2023 · 3 comments · Fixed by #2977
Closed

Multipass GUI notification gets annoying after a while #2975

ricab opened this issue Mar 17, 2023 · 3 comments · Fixed by #2977
Assignees
@ricab
Labels
bug
Milestone
1.12.0

Comments

@ricab
Copy link
Collaborator

ricab commented Mar 17, 2023

Describe the bug
Originally reported on discourse.

It’s good for fist time. But after two years…

image

And notification settings don’t work

image
@ricab ricab added the bug label Mar 17, 2023
@ricab
Copy link
Collaborator Author

ricab commented Mar 17, 2023

We should honour that "notifications" setting (on all platforms).

Furthermore, we need to think of how best to avoid being annoying. Maybe we should show the notification only N times, or not at all unless it's a new install.

@ricab
Copy link
Collaborator Author

ricab commented Mar 17, 2023

Looking at the code, the intention is to only show this on the first run. I wonder why the user is seeing it repeatedly. Maybe they are purging data?

@ricab
Copy link
Collaborator Author

ricab commented Mar 17, 2023

Nevermind, the notification is coming up here whenever I just launch the GUI. Definitely not the intention.

@ricab ricab mentioned this issue Mar 17, 2023
Merged
ricab added a commit that referenced this issue Mar 17, 2023
@ricab
[gui] Fix creating first_run file if dir not there
8c1309d 
Create the AppDataLocation dir for the Multipass GUI if it does not yet
exist. Keep `first_run`, in case the directory could be created some
other way. Fixes #2975.
@georgeliao georgeliao modified the milestone: 1.12.0 Mar 19, 2023
@sharder996 sharder996 added this to the 1.12.0 milestone Mar 20, 2023
bors bot added a commit that referenced this issue Mar 20, 2023
@bors @ricab
Merge #2977
9b60088 
2977: [gui] Fix creating first_run file if dir not there r=sharder996 a=ricab

Create the AppDataLocation dir for the Multipass GUI if it does not yet exist. Keep `first_run`, in case the directory could be created some other way. Fixes #2975.


Co-authored-by: Ricardo Abreu <ricardo.abreu@canonical.com>
bors bot added a commit that referenced this issue Mar 20, 2023
@bors @ricab
Merge #2977
79dae9d 
2977: [gui] Fix creating first_run file if dir not there r=sharder996 a=ricab

Create the AppDataLocation dir for the Multipass GUI if it does not yet exist. Keep `first_run`, in case the directory could be created some other way. Fixes #2975.


Co-authored-by: Ricardo Abreu <ricardo.abreu@canonical.com>
bors bot added a commit that referenced this issue Mar 20, 2023
@bors @ricab
Merge #2977
2b1d734 
2977: [gui] Fix creating first_run file if dir not there r=sharder996 a=ricab

Create the AppDataLocation dir for the Multipass GUI if it does not yet exist. Keep `first_run`, in case the directory could be created some other way. Fixes #2975.


Co-authored-by: Ricardo Abreu <ricardo.abreu@canonical.com>
bors bot added a commit that referenced this issue Mar 20, 2023
@bors @ricab
Merge #2977
ed8d21a 
2977: [gui] Fix creating first_run file if dir not there r=sharder996 a=ricab

Create the AppDataLocation dir for the Multipass GUI if it does not yet exist. Keep `first_run`, in case the directory could be created some other way. Fixes #2975.


Co-authored-by: Ricardo Abreu <ricardo.abreu@canonical.com>
ricab added a commit that referenced this issue Mar 21, 2023
@ricab
Merge pull request #2977 from canonical/fix-repeating-gui-notification
2c5d31d 
2977: [gui] Fix creating first_run file if dir not there r=sharder996 a=ricab

Create the AppDataLocation dir for the Multipass GUI if it does not yet exist. Keep `first_run`, in case the directory could be created some other way. Fixes #2975.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricab ricab

Labels
bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging a pull request may close this issue.

[gui] Fix creating first_run file if dir not there canonical/multipass
3 participants
@georgeliao @ricab @sharder996