Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multipass clone #3264

Merged
merged 175 commits into from
Oct 19, 2024
Merged

Multipass clone #3264

merged 175 commits into from
Oct 19, 2024

Commits on Oct 18, 2024

  1. [grpc] Added multipass clone protobuf message place holder.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    04edba5 View commit details
    Browse the repository at this point in the history

  2. [grpc] Added missing fields of clone message

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d4c91dc View commit details
    Browse the repository at this point in the history

  3. [cli] Added clone command line class and functions interfaces.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0f176fc View commit details
    Browse the repository at this point in the history

  4. [cli] Added parse_args implementation and invocation.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    bee3d5f View commit details
    Browse the repository at this point in the history

  5. [cli] Added grpc code on the frond end.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    9913e7e View commit details
    Browse the repository at this point in the history

  6. [grpc] Create the rpc framework for daemon::clone function.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    76cde47 View commit details
    Browse the repository at this point in the history

  7. Added rpc_request fill-in code on the front end.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    bb82bdd View commit details
    Browse the repository at this point in the history

  8. Added source_name validity check.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    721bc98 View commit details
    Browse the repository at this point in the history

  9. Added specified destination name check.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5b63819 View commit details
    Browse the repository at this point in the history

  10. Added generating destination name.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    765a7b7 View commit details
    Browse the repository at this point in the history

  11. Added the source instance state check.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    e013ec8 View commit details
    Browse the repository at this point in the history

  12. Small renaming for the vm instance pointer variable

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7a94ff9 View commit details
    Browse the repository at this point in the history

  13. Formatted legacy code diff on this branch based on the new .clang-for… 

    …mat file.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    fbac81d View commit details
    Browse the repository at this point in the history

  14. [daemon] Added clone_spec_item_and_write_to_instance_db lambda functi… 

    …on the caller.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    fe57d66 View commit details
    Browse the repository at this point in the history

  15. [daemon] Wrap the destination name related code into generate_destina… 

    …tion_name function.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    8159284 View commit details
    Browse the repository at this point in the history

  16. [imageVault] Added clone method for DefaultVMImageVault class

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    bad2e30 View commit details
    Browse the repository at this point in the history

  17. [daemon] Added vault clone method interface and the caller of that.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    6e8b233 View commit details
    Browse the repository at this point in the history

  18. [daemon] Added the code of virtual machine instance folder copy.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5aac25c View commit details
    Browse the repository at this point in the history

  19. [file_ops] Added copy file wrapper function.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    796e56b View commit details
    Browse the repository at this point in the history

  20. [daemon] replace the std file copy function with the wrapper one.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    b820cfd View commit details
    Browse the repository at this point in the history

  21. [daemon] added qemu_iso and the meta_data and network-config parts.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    002a1fa View commit details
    Browse the repository at this point in the history

  22. [daemon] Added mount directory creation.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7f030a7 View commit details
    Browse the repository at this point in the history

  23. [daemon] Added mount command for the iso file.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    01809cb View commit details
    Browse the repository at this point in the history

  24. [daemon] add the loading the same parts of iso file and write to the … 

    …new cloned one.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    73b7332 View commit details
    Browse the repository at this point in the history

  25. [daemon] Added unmount command.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    3c410a7 View commit details
    Browse the repository at this point in the history

  26. [daemon] Added removing directory.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    a79d3d9 View commit details
    Browse the repository at this point in the history

  27. [daemon] added create_virtual_machine and init_mount code for destina… 

    …tion vm.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d43e65a View commit details
    Browse the repository at this point in the history

  28. [daemon] fix the compiler warning which caused the build failure.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    6c7b65c View commit details
    Browse the repository at this point in the history

  29. [daemon] small fix for rebase conflict.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    4ea7e4d View commit details
    Browse the repository at this point in the history

  30. [daemon, cli] Added the reply message of clone and improved the clone… 

    … help message.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    26b0c5c View commit details
    Browse the repository at this point in the history

  31. [snapshot] modified the find_parent function and added call to snapsh… 

    …ot copy constructor.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c5dd274 View commit details
    Browse the repository at this point in the history

  32. [snapshot] added qemu_snapshot constructor that is based on another s… 

    …napshot.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5d67cb8 View commit details
    Browse the repository at this point in the history

  33. [snapshot] added clone function interface.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0484fc5 View commit details
    Browse the repository at this point in the history

  34. [virtual_machine] added clone method of qemu virtual machine

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    f41e9d3 View commit details
    Browse the repository at this point in the history

  35. [virtual machine] added clone_snapshots method place holder.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d10d45d View commit details
    Browse the repository at this point in the history

  36. [virtual machine] small name improvement for the snapshot clone funct… 

    …ion.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c40bb39 View commit details
    Browse the repository at this point in the history

  37. [snapshot] fix the constness of snapshot classes

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    932cf33 View commit details
    Browse the repository at this point in the history

  38. [virtual machine] fix the constness of snapshot in clone_one_snapshot… 

    … function.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    b4f54b8 View commit details
    Browse the repository at this point in the history

  39. [snapshot] reverted the in RAM clone snapshot related code.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d4d6d7e View commit details
    Browse the repository at this point in the history

  40. [snapshot] added new constructor for for constructing from file and r… 

    …eplace unique identifiers.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2699d99 View commit details
    Browse the repository at this point in the history

  41. [snapshot] added qemu_snapshot constructor.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    35852bd View commit details
    Browse the repository at this point in the history

  42. [virtual machine] added make_specific_snapshot function place holder

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0a3f172 View commit details
    Browse the repository at this point in the history

  43. [virtual machine] added make_specific_snapshot qemu implementation.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    8b15557 View commit details
    Browse the repository at this point in the history

  44. [virtual machine] added public method load_snapshots_and_update_uniqu… 

    …e_identifiers place holder.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    075f490 View commit details
    Browse the repository at this point in the history

  45. [virtual machine] added load one file to snapshot function. PS: refac… 

    …toring will be done later due to the code duplication.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    f53141d View commit details
    Browse the repository at this point in the history

  46. [daemon] added the loading and updating snapshots calls, now the whol… 

    …e pipeline works properly.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    70af451 View commit details
    Browse the repository at this point in the history

  47. [json] added update_unique_identifiers_of_metadata function and refac… 

    …tored the corresponding code.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0f6a5fa View commit details
    Browse the repository at this point in the history

  48. [virtual machine] added load_snapshots_common to reduce the repeated … 

    …code.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    4be8396 View commit details
    Browse the repository at this point in the history

  49. [virtual machine] added variadic templated function load_snapshot_and… 

    …_optionally_update_unique_identifiers to reduce the repeated code.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    8e8c6d1 View commit details
    Browse the repository at this point in the history

  50. [virtual machine] changed load_snapshots_common function to variadic … 

    …template for better readability.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    75047f9 View commit details
    Browse the repository at this point in the history

  51. [virtual machine] added explanatory comment for load_snapshots_common… 

    … method.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    1a6d81f View commit details
    Browse the repository at this point in the history

  52. [cli] replaced the destination name positional argument with option.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    e3dac8c View commit details
    Browse the repository at this point in the history

  53. [cli] fix the warning (compilation error) after upgrading to ubuntu 2… 

    …3.10.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    e89cfcb View commit details
    Browse the repository at this point in the history

  54. [cli] fixed and refined the destination name description.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    51ae48c View commit details
    Browse the repository at this point in the history

  55. [daemon] added destination name validity check.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    1fb24b0 View commit details
    Browse the repository at this point in the history

  56. [virtual machine] improved the name generator based on the team discu… 

    …ssion.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    94ae9a2 View commit details
    Browse the repository at this point in the history

  57. [utils] move some yaml helpers functions into utils.cpp to set up the… 

    … refactoring.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    1195958 View commit details
    Browse the repository at this point in the history

  58. [daemon] small refactoring, localize the lambda function further.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5267c6f View commit details
    Browse the repository at this point in the history

  59. [vm factory] added create_vm_and_instance_disk_data function for clon… 

    …ing process.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7b5d54f View commit details
    Browse the repository at this point in the history

  60. [vm factory] added create_vm_and_instance_disk_data interface and cal… 

    …l it in the daemon. Thus, remove the code cluster there.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    a650c83 View commit details
    Browse the repository at this point in the history

  61. [vm factory] using the new read_from function to read the cloud-init-… 

    …config.iso instead of mounting.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    900a2e7 View commit details
    Browse the repository at this point in the history

  62. [cloud init] added at operator, it is similar with std::unordered_map… 

    … at operator.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5d7b9fb View commit details
    Browse the repository at this point in the history

  63. [vm factory] added load string and replace name functionality of make… 

    …_cloud_init_meta_config and use it in the client code.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    64d0330 View commit details
    Browse the repository at this point in the history

  64. [cloud init] added contains function.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    4f082a2 View commit details
    Browse the repository at this point in the history

  65. [vm factory] refine the client code of make_cloud_init_network_config… 

    … based on the new utility functions.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d4b1eea View commit details
    Browse the repository at this point in the history

  66. [cloud init] clean up some CloudInitIso utility functions/

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    8d33f55 View commit details
    Browse the repository at this point in the history

  67. [vm factory] added early back-end check for the clone operation.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    b32634c View commit details
    Browse the repository at this point in the history

  68. [json util] refined on the source name to destination name string rep… 

    …lacement.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    4d313a8 View commit details
    Browse the repository at this point in the history

  69. [daemon] added run_at_boot commands unique identifiers update for clo… 

    …ne (not tested).
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c888720 View commit details
    Browse the repository at this point in the history

  70. [daemon] moved cloned_instance_count from virtual machine class to vm… 

    …spec.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    bcd8b75 View commit details
    Browse the repository at this point in the history

  71. [daemon] fix a small error from the previous commit.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c4cc8fb View commit details
    Browse the repository at this point in the history

  72. [daemon] refined the clone_spec_item function.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5345442 View commit details
    Browse the repository at this point in the history

  73. [daemon] use find_instance_and_react to make the error report of clon… 

    …e more congruent with other operations.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    e00e48b View commit details
    Browse the repository at this point in the history

  74. [daemon] correct the extra interfaces update in clone.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    69a4b6e View commit details
    Browse the repository at this point in the history

  75. [daemon] removed update_extra_interfaces_mac_address_of_run_at_boot s… 

    …ince run_at_boot does not have commands in the stop state in the case of extra interface.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    6fe05f4 View commit details
    Browse the repository at this point in the history

  76. [vm factory] added scope_guard clean up function for the create_vm_an… 

    …d_instance_disk_data function.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7a557b4 View commit details
    Browse the repository at this point in the history

  77. [cloud init] rebase fix.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    35a635e View commit details
    Browse the repository at this point in the history

  78. [json utils] fix formatting.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ac429f7 View commit details
    Browse the repository at this point in the history

  79. fixed the post-merge compilation.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    9323388 View commit details
    Browse the repository at this point in the history

  80. [bash completion] added clone bash completion

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d175ac4 View commit details
    Browse the repository at this point in the history

  81. [unit test] added clone cli tests.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    422e13e View commit details
    Browse the repository at this point in the history

  82. [unit test][daemon] added the daemon clone unit test frame work.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    3169f94 View commit details
    Browse the repository at this point in the history

  83. [unit test][daemon] added unusual unit test case.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c7360d6 View commit details
    Browse the repository at this point in the history

  84. [unit test][daemon] added failsOnCloneOnNonStoppedInstance test.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    f181f2b View commit details
    Browse the repository at this point in the history

  85. rebase fix.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    6f69d82 View commit details
    Browse the repository at this point in the history

  86. [yaml utils] made the make_cloud_init_meta_config to update instance_… 

    …id as well.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    55cf5d1 View commit details
    Browse the repository at this point in the history

  87. [json utils] added updating cloud init instance id in snapshot file c… 

    …opying.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    51dd340 View commit details
    Browse the repository at this point in the history

  88. [unit test][json utils] added unit tests for update_cloud_init_instan… 

    …ce_id funciton.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    37887e7 View commit details
    Browse the repository at this point in the history

  89. [json utils] changed update_unique_identifiers_of_metadata parameter … 

    …from QJsonObject to QJsonValue for consistency.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    234b624 View commit details
    Browse the repository at this point in the history

  90. [clone] small comment correction.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    e453aed View commit details
    Browse the repository at this point in the history

  91. [clone] small cleanup for some comments.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    23e38a0 View commit details
    Browse the repository at this point in the history

  92. [daemon] refined the the roll back mechanism in clone.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    4c68748 View commit details
    Browse the repository at this point in the history

  93. [unit test] added more unit tests for client failed command line args… 

    … check.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2f2f7df View commit details
    Browse the repository at this point in the history

  94. [unit test] added clone invalid option unit test.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7f0daea View commit details
    Browse the repository at this point in the history

  95. [cmd] added AnimatedSpinner to clone command.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    3d1498c View commit details
    Browse the repository at this point in the history

  96. [client][unit test] added command fail error to cover action_on_failu… 

    …re branch of cmd dispatch.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    61fb14d View commit details
    Browse the repository at this point in the history

  97. [vm factory] use in class data member instances_dir to derive the sou… 

    …rce and destination instance folders.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    a88cc7c View commit details
    Browse the repository at this point in the history

  98. [vm image] improve one function parameter name.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    b4b5cb0 View commit details
    Browse the repository at this point in the history

  99. [clone] function name improvement.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    e5aa10c View commit details
    Browse the repository at this point in the history

  100. [clone] added update_cloned_cloud_init utility function.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    84268c0 View commit details
    Browse the repository at this point in the history

  101. [cloud init] [unit test] added unit test for update_cloned_cloud_init… 

    … function.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    4fb01ce View commit details
    Browse the repository at this point in the history

  102. [vm factory] use update_cloned_cloud_init function to prepare for uni… 

    …t test mocking.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    38383b6 View commit details
    Browse the repository at this point in the history

  103. [unit test] added FileOps::copy unit test.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0068185 View commit details
    Browse the repository at this point in the history

  104. [image vault] added unit test for DefaultVMImageVault::clone.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0a413ac View commit details
    Browse the repository at this point in the history

  105. [image vault] [unit test] added imageCloneFailOnNonExistSrcImage case.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ff5a356 View commit details
    Browse the repository at this point in the history

  106. [image vault] [unit test] added imageCloneFailOnAlreadyExistDestImage… 

    … unit test.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    115c120 View commit details
    Browse the repository at this point in the history

  107. [lxd image vault][unit test] added lxdImageVaultCloneThrow unit test.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    daa8163 View commit details
    Browse the repository at this point in the history

  108. [unit test] added coverage for DaemonRpc::clone.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    f8cab93 View commit details
    Browse the repository at this point in the history

  109. [daemon] small refactor on generate_next_clone_name function.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    cb42546 View commit details
    Browse the repository at this point in the history

  110. [cloud init] small function name improvement and typo correction.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    8c9af34 View commit details
    Browse the repository at this point in the history

  111. [vm image] improves the image_path sub-string replacement, get it con… 

    …sistent with the metadata sub-string replacement in JsonUtils::update_unique_identifiers_of_metadata.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    222125e View commit details
    Browse the repository at this point in the history

  112. [qemu][vm factory] fixed rollback instance directory removal did not … 

    …work bug.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ea4b023 View commit details
    Browse the repository at this point in the history

  113. [clone] added metadata non-empty check for the non-qemu backend cases.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0316146 View commit details
    Browse the repository at this point in the history

  114. [unit test] removed assertion line coverage unit test because windows… 

    … ci use relwithdebinfo mode and that does hit the assertion.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    6a82802 View commit details
    Browse the repository at this point in the history

  115. [qemu][vm factory] using the QemuVirtualMachine constructor directly … 

    …instead of the QemuVirtualMachineFactory::create_virtual_machine public function.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    73f609a View commit details
    Browse the repository at this point in the history

  116. [qemu][vm factory] added copy_instance_dir_without_snapshot_files fun… 

    …ction and replace copying the whole directory call with that.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    471e6c2 View commit details
    Browse the repository at this point in the history

  117. [qemu] remove all load_snapshots_and_update_unique_identifiers relate… 

    …d code.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5cade6a View commit details
    Browse the repository at this point in the history

  118. [virtual machine] added the placeholder of the remove_all_snapshots_f… 

    …rom_the_image function.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    6fe8503 View commit details
    Browse the repository at this point in the history

  119. [qemu][virtual machine] added qemu remove_all_snapshots_from_the_imag… 

    …e implementation and call it in the factory class.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ec2ad45 View commit details
    Browse the repository at this point in the history

  120. [vm] removed get_vm_name because it is not needed.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    82f2912 View commit details
    Browse the repository at this point in the history

  121. [cli] improve the command description based on review comments.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    471441b View commit details
    Browse the repository at this point in the history

  122. [daemon] use release_resources function to simplify the roll back mec… 

    …hanism.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    07ce457 View commit details
    Browse the repository at this point in the history

  123. [daemon] moving is_name_already_used from local lambda to private fun… 

    …ction.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0bc09e2 View commit details
    Browse the repository at this point in the history

  124. [daemon] moving generate_destination_name and clone_spec to private f… 

    …unctions.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2c2ae05 View commit details
    Browse the repository at this point in the history

  125. [json utils] refined the update_cloud_init_instance_id function.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d01aad4 View commit details
    Browse the repository at this point in the history

  126. [lxd][vm image] Using NotImplementedOnThisBackendException to be more… 

    … generic.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    8ab0d86 View commit details
    Browse the repository at this point in the history

  127. [qemu factory] simplified the copy_instance_dir_without_snapshot_file… 

    …s function.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    143b353 View commit details
    Browse the repository at this point in the history

  128. [daemon] using instance_trail to get the source_vm_ptr pointer to sav… 

    …e one operative_instances search.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    190e628 View commit details
    Browse the repository at this point in the history

  129. [daemon] added cloneInvalidNameException and set the corresponding gr… 

    …pc::StatusCode.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ff3dd33 View commit details
    Browse the repository at this point in the history

  130. [daemon][cli] small wording improvement.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    1c2043a View commit details
    Browse the repository at this point in the history

  131. [daemon] added preparing_instances for clone operation, followed the … 

    …tune of launch.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    a2ffd75 View commit details
    Browse the repository at this point in the history

  132. [lxd] fixed one unit test.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7b36cc4 View commit details
    Browse the repository at this point in the history

  133. [daemon] polishing some daemon::clone code

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    9f35acd View commit details
    Browse the repository at this point in the history

  134. [daemon] added invalidDestVmName test.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d1fa995 View commit details
    Browse the repository at this point in the history

  135. [unit test] change the instance_name for better clarity.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    1e3da06 View commit details
    Browse the repository at this point in the history

  136. [unit test][daemon] added alreadyExistDestVmName unit test.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    a5189d0 View commit details
    Browse the repository at this point in the history

  137. [unit test] added unit test for qemu removeAllSnapshotsFromTheImage.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    6bd23c4 View commit details
    Browse the repository at this point in the history

  138. [qemu][unit test] added createVmAndCloneInstanceDirData test.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    8f6a887 View commit details
    Browse the repository at this point in the history

  139. [unit test][daemon] added the extra interface so the daemon::clone su… 

    …ccessful case is more general. As a result, it covers update_unique_identifiers_of_metadata all branches.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    744930b View commit details
    Browse the repository at this point in the history

  140. [qemu][unit test] added mocked snapshot_list output stream to cover s… 

    …ome for loops.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    86ed748 View commit details
    Browse the repository at this point in the history

  141. Update src/daemon/daemon.cpp 

    Co-authored-by: ScottH <59572507+sharder996@users.noreply.github.com>
Signed-off-by: George Liao <georgeliaojia@gmail.com>
    @georgeliao @sharder996 @ricab
    2 people authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    55b1bbe View commit details
    Browse the repository at this point in the history

  142. [daemon] small format correction.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ce4fe10 View commit details
    Browse the repository at this point in the history

  143. [daemon] small wording improvement.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    43c5d79 View commit details
    Browse the repository at this point in the history

  144. [daemon] fix the format.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    db55643 View commit details
    Browse the repository at this point in the history

  145. [daemon][unit test] added successfulCloneSpecifyDestNameOkStatus unit… 

    … test.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    b5819e1 View commit details
    Browse the repository at this point in the history

  146. Update src/client/cli/cmd/clone.cpp 

    Co-authored-by: ScottH <59572507+sharder996@users.noreply.github.com>
Signed-off-by: George Liao <georgeliaojia@gmail.com>
    @georgeliao @sharder996 @ricab
    2 people authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ecb1c48 View commit details
    Browse the repository at this point in the history

  147. renaming the function name from remove_all_snapshots_from_the_image t… 

    …o remove_snapshots_from_image
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    cd8c635 View commit details
    Browse the repository at this point in the history

  148. [unit test][daemon] removed the unused data member.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    e42f019 View commit details
    Browse the repository at this point in the history

  149. [unit test][qemu] improved unit test createVmAndCloneInstanceDirData … 

    …based on review comment.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0fba52a View commit details
    Browse the repository at this point in the history

  150. [daemon][unit test] small header cleanup.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    fc49f0f View commit details
    Browse the repository at this point in the history

  151. Update src/platform/backends/lxd/lxd_vm_image_vault.h 

    Co-authored-by: ScottH <59572507+sharder996@users.noreply.github.com>
Signed-off-by: George Liao <georgeliaojia@gmail.com>
    @georgeliao @sharder996 @ricab
    2 people authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    b6178dc View commit details
    Browse the repository at this point in the history

  152. [daemon][qemu unit test] small format improvement.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2997b18 View commit details
    Browse the repository at this point in the history

  153. [daemon] added preparing_instances removal to the rollback_clean_up_a… 

    …ll_resource_of_dest_instance.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    25e0f3c View commit details
    Browse the repository at this point in the history

  154. [unit test] fix the unit test.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    74cd086 View commit details
    Browse the repository at this point in the history

  155. [qemu][unit test] improved the removeAllSnapshotsFromTheImage unit test.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0b44530 View commit details
    Browse the repository at this point in the history

  156. Use char* variable for cloud-init-config.iso string literal

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    edd2959 View commit details
    Browse the repository at this point in the history

  157. [unit test] small tuning of the string construction.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    eca44a8 View commit details
    Browse the repository at this point in the history

  158. Update src/daemon/daemon.cpp 

    Co-authored-by: ScottH <59572507+sharder996@users.noreply.github.com>
Signed-off-by: George Liao <georgeliaojia@gmail.com>
    @georgeliao @sharder996 @ricab
    2 people authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0c70383 View commit details
    Browse the repository at this point in the history

  159. [daemon] changing throwing to early return.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    56aac9e View commit details
    Browse the repository at this point in the history

  160. [daemon] move the srt vm state before the rollback and generating des… 

    …t name.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    a5470e7 View commit details
    Browse the repository at this point in the history

  161. [daemon] converted from regular try-catch to function try-catch

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    64e33de View commit details
    Browse the repository at this point in the history

  162. [yaml utils] small header format improvement.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    164a058 View commit details
    Browse the repository at this point in the history

  163. [yaml utils] make default interface node always present in the case o… 

    …f cloning and creating cloud-init.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    4174847 View commit details
    Browse the repository at this point in the history

  164. [yaml utils] refactored the create_default_interface_node code into a… 

    … function.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    eb47317 View commit details
    Browse the repository at this point in the history

  165. [yaml utils] added dhcp-identifier: mac to all network interfaces.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d04b2fb View commit details
    Browse the repository at this point in the history

  166. [cloud init] fixed the update_cloned_cloud_init_unique_identifiers di… 

    …d not network file issue.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5ff2dd7 View commit details
    Browse the repository at this point in the history

  167. [qemu img utils] move snapshot -l into a function

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    1425605 View commit details
    Browse the repository at this point in the history

  168. [qemu img utils] move snapshot -d code into a function.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    34e95f4 View commit details
    Browse the repository at this point in the history

  169. [qemu img utils] removed repeated qemu img utils function.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7ef3114 View commit details
    Browse the repository at this point in the history

  170. [yaml utils] added comments for the new make_cloud_init_network_confi… 

    …g and add_extra_interface_to_network_config function.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d9150b3 View commit details
    Browse the repository at this point in the history

  171. [qemu][unit test] corrected and improved the unit test removeAllSnaps… 

    …hotsFromTheImage.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    fe6eb5a View commit details
    Browse the repository at this point in the history

  172. [test cloud_init] change std::string_view to char* to adhere to the s… 

    …tyle of the rest code.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    eeeae51 View commit details
    Browse the repository at this point in the history

  173. [virtual machine] improve the exception message.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    58a3cba View commit details
    Browse the repository at this point in the history

  174. [vm factory] created the instance folder copy utility function and us… 

    …e it in qemu factory.
    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    b276845 View commit details
    Browse the repository at this point in the history

  175. [cmd] improved the clone help text based the documentation review.

    @georgeliao @ricab
    georgeliao authored and ricab committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    cf96ba7 View commit details
    Browse the repository at this point in the history