Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to paas-app-charmer 1.0.4 #35

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Adapt to paas-app-charmer 1.0.4 #35

merged 5 commits into from
Jul 30, 2024

Conversation

javierdelapuente
Copy link
Collaborator

@javierdelapuente javierdelapuente commented Jul 5, 2024

Overview

The following code and tests were removed, as now they are implemented in paas-app-charmer:

  • S3 integration.
  • saml integration
  • BASE_URL as comes from the ingress url
  • block on missing integration

Also the config aws-endpoint-url has been removed, as the issue was fixed upstream.

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@javierdelapuente javierdelapuente changed the title Use S3 and SAML from paas-app-charmer 1.0.3 Adapt to paas-app-charmer 1.0.4 Jul 12, 2024
@javierdelapuente javierdelapuente marked this pull request as ready for review July 29, 2024 15:31
@javierdelapuente javierdelapuente requested a review from a team as a code owner July 29, 2024 15:31
Copy link
Contributor

Test coverage for 1ea65a8

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py      42     26      8      1    34%   30-70, 74-83, 93-103, 118, 126, 142, 152
----------------------------------------------------------
TOTAL             42     26      8      1    34%

Static code analysis report

Run started:2024-07-29 15:26:48.683200

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 766
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love removing code! LGTM!

@javierdelapuente javierdelapuente merged commit b1601ef into main Jul 30, 2024
19 checks passed
@javierdelapuente javierdelapuente deleted the remove-s3-saml branch July 30, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants