Add in-place upgrades #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO:
|
carlcsaposs-canonical
force-pushed
the
upgrades
branch
3 times, most recently
from
1c3e3df
to
31a9651
Compare
This reverts commit 39e5075.
phvalguima
requested changes
Apr 24, 2024
|
@Mehdi-Bendriss I haven't updated the guards for non-upgrade event handlers since #190—let me know if there's anything I should update Given that the scope of this PR is upgrades for simple deployments only, not sure what's desired here |
Co-authored-by: phvalguima <pedro.guimaraes@canonical.com>
This was referenced Apr 24, 2024
phvalguima
added a commit
that referenced
this pull request
Apr 26, 2024
Spin of #242, [following this discussion](#242 (review)). Adds an integration test to ensure we have the correct version in the `workload_version` file. --------- Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com>
phvalguima
previously approved these changes
Apr 26, 2024
Mehdi-Bendriss
approved these changes
Apr 29, 2024
phvalguima
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from canonical/mysql-router-operator#88
upgrade.py, machine_upgrade.py and event handlers in charm.py are mostly shared with upgrade.py, machine_upgrade.py and event handlers in abstract_charm.py/machine_charm.py in MySQL Router VM charm
Non-upgrade event handler guards implemented per https://docs.google.com/spreadsheets/d/1_qjINUoj5Mi7PlXhCdpwQ0170bIZSgpvNFMAnTOtuQw/edit#gid=0