[DPE 4135][DPE-3953] Add pre checks upgrade and Integration Tests #267

phvalguima · 2024-04-29T12:38:52Z

Implements the pre-upgrade-checks and integration tests for small deployments upgrade.

lib/charms/opensearch/v0/opensearch_backups.py

lib/charms/opensearch/v0/opensearch_base_charm.py

src/upgrade.py

src/opensearch.py

carlcsaposs-canonical · 2024-04-30T09:52:18Z

should we check that a backup exists?

phvalguima · 2024-04-30T10:28:14Z

should we check that a backup exists?

@carlcsaposs-canonical @medib in my opinion, yes but then how long before? A day, an hour? Too far and it is an almost useless check, too short and a big cluster will always fail the pre-upgrade-checks.

carlcsaposs-canonical · 2024-04-30T10:34:02Z

should we check that a backup exists?

@carlcsaposs-canonical @medib in my opinion, yes but then how long before? A day, an hour? Too far and it is an almost useless check, too short and a big cluster will always fail the pre-upgrade-checks.

good question, but at the least, IMO, checking that at least 1 backup exists is better than no backup at all

lib/charms/opensearch/v0/opensearch_backups.py

src/upgrade.py

tests/integration/test_small_deployment_upgrades.py

Mehdi-Bendriss

Thanks Pedro, I left some comments. Overall - I don't immediately see the need to alter the opensearch_distro if we only support upgrades from 2.12 (upgrades from older versions wthout the upgrades implementation is not supported)

lib/charms/opensearch/v0/helper_cluster.py

lib/charms/opensearch/v0/opensearch_backups.py

src/opensearch.py

Co-authored-by: Mehdi Bendriss <bendrissmehdi@gmail.com>

lib/charms/opensearch/v0/opensearch_backups.py

lib/charms/opensearch/v0/helper_charm.py

lib/charms/opensearch/v0/opensearch_backups.py

src/upgrade.py

tests/integration/test_small_deployment_upgrades.py

…ks-upgrade

phvalguima · 2024-05-06T10:29:44Z

question: what version are you upgrading from in the tests?
would it make more sense to upgrade the local version of the charm & change the snap rev so that the stability of this test is not affected by an external charm?
or is the intention to always test against edge or stable of opensearch?

@carlcsaposs-canonical, this is just a really temporary step. I am packing this same PR but with snap rev40 instead of rev44. I release it under pguimaraes-opensearch-upgrade-test for now.

I will revisit this logic later this week, once I packed the newer 2.13 and 2.14 releases.
Here is the ticket to track it: https://warthogs.atlassian.net/browse/DPE-4284

…ection error

Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com>

carlcsaposs-canonical · 2024-05-06T10:40:04Z

@carlcsaposs-canonical, this is just a really temporary step. I am packing this same PR but with snap rev40 instead of rev44. I release it under pguimaraes-opensearch-upgrade-test for now.

I will revisit this logic later this week, once I packed the newer 2.13 and 2.14 releases. Here is the ticket to track it: https://warthogs.atlassian.net/browse/DPE-4284

#267 (comment)

carlcsaposs-canonical

looks good, one open question

src/upgrade.py

Co-authored-by: Mehdi Bendriss <bendrissmehdi@gmail.com>

carlcsaposs-canonical force-pushed the pre-upgrade-check branch 2 times, most recently from 60c3f48 to 3613bf5 Compare April 29, 2024 14:17

phvalguima requested review from Mehdi-Bendriss and carlcsaposs-canonical April 30, 2024 08:16

Base automatically changed from pre-upgrade-check to main April 30, 2024 08:21

phvalguima added 4 commits April 30, 2024 10:36

Remove relation_{joined,changed}.emit() calls

8c667ed

Clean-up passing config-changed around

45339f1

Forgotten lint fix

2a3295d

Add pre-upgrade-checks and 1st integration test

7eced26

phvalguima changed the base branch from main to DPE-4224-remove-relation-emits April 30, 2024 08:51

phvalguima force-pushed the DPE-4135-add-pre-checks-upgrade branch from 34b7441 to 7eced26 Compare April 30, 2024 08:54

carlcsaposs-canonical reviewed Apr 30, 2024

View reviewed changes

Adding first PR review comments

495552a

phvalguima requested a review from carlcsaposs-canonical April 30, 2024 10:26

carlcsaposs-canonical reviewed Apr 30, 2024

View reviewed changes

phvalguima requested a review from carlcsaposs-canonical April 30, 2024 12:44

phvalguima added 2 commits April 30, 2024 14:45

Fix upgrade.py

39b4b10

Fix upgrade.py to use self._charm.unit

cc4a6ed

Mehdi-Bendriss reviewed Apr 30, 2024

View reviewed changes

Base automatically changed from DPE-4224-remove-relation-emits to main May 1, 2024 14:59

Mehdi-Bendriss added 7 commits May 1, 2024 19:26

Remove roles reassigning from tests (#245)

3f70a18

add apply health wait for green first

9ac3b71

Add correct number of units for scaling test

4ed7479

Temp commenting of unit test

b354e03

init test

c06a72b

Bump juju to 3.3.4

f95638c

Added large deployments tests

5014332

phvalguima and others added 5 commits May 4, 2024 22:37

Update lib/charms/opensearch/v0/opensearch_backups.py

7e43d5a

Co-authored-by: Mehdi Bendriss <bendrissmehdi@gmail.com>

Update opensearch_base_charm.py

49021a4

Update upgrade.py

80fe673

Update upgrade.py

37293ae

fix error

1ca9cf3

phvalguima requested a review from Mehdi-Bendriss May 4, 2024 21:01

carlcsaposs-canonical reviewed May 6, 2024

View reviewed changes

Merge remote-tracking branch 'origin/main' into DPE-4135-add-pre-chec…

61a5e58

…ks-upgrade

phvalguima and others added 5 commits May 6, 2024 12:31

{backup/restore}_in_progress should default to True if we have a conn…

c32470e

…ection error

Update src/upgrade.py

03fc524

Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com>

Update src/upgrade.py

50bad98

Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com>

Update tests/integration/test_small_deployment_upgrades.py

97b05f0

Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com>

Lint fixes

cfce4c4

phvalguima mentioned this pull request May 6, 2024

resume-upgrade returns failed although the charm is ready for upgrade #299

Closed

phvalguima added 2 commits May 6, 2024 12:57

Update test_small_deployment_upgrades.py

088da04

Update test_small_deployment_upgrades.py

61af020

phvalguima requested a review from carlcsaposs-canonical May 6, 2024 12:12

carlcsaposs-canonical previously approved these changes May 6, 2024

View reviewed changes

src/upgrade.py Outdated Show resolved Hide resolved

Update upgrade.py

014b7a8

phvalguima dismissed carlcsaposs-canonical’s stale review via 014b7a8 May 6, 2024 14:08

phvalguima added 3 commits May 6, 2024 16:17

Update upgrade.py

881bca9

fix lint

631f817

Update upgrade.py

71f8619

Mehdi-Bendriss previously approved these changes May 6, 2024

View reviewed changes

src/upgrade.py Outdated Show resolved Hide resolved

Update src/upgrade.py

38644b8

Co-authored-by: Mehdi Bendriss <bendrissmehdi@gmail.com>

phvalguima dismissed Mehdi-Bendriss’s stale review via 38644b8 May 7, 2024 05:05

phvalguima merged commit 6670d19 into main May 7, 2024
10 checks passed

phvalguima deleted the DPE-4135-add-pre-checks-upgrade branch May 7, 2024 05:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DPE 4135][DPE-3953] Add pre checks upgrade and Integration Tests #267

[DPE 4135][DPE-3953] Add pre checks upgrade and Integration Tests #267

phvalguima commented Apr 29, 2024

carlcsaposs-canonical commented Apr 30, 2024

phvalguima commented Apr 30, 2024

carlcsaposs-canonical commented Apr 30, 2024

Mehdi-Bendriss left a comment

phvalguima commented May 6, 2024

carlcsaposs-canonical commented May 6, 2024

carlcsaposs-canonical left a comment

[DPE 4135][DPE-3953] Add pre checks upgrade and Integration Tests #267

[DPE 4135][DPE-3953] Add pre checks upgrade and Integration Tests #267

Conversation

phvalguima commented Apr 29, 2024

carlcsaposs-canonical commented Apr 30, 2024

phvalguima commented Apr 30, 2024

carlcsaposs-canonical commented Apr 30, 2024

Mehdi-Bendriss left a comment

Choose a reason for hiding this comment

phvalguima commented May 6, 2024

carlcsaposs-canonical commented May 6, 2024

carlcsaposs-canonical left a comment

Choose a reason for hiding this comment