Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase logging when index creation fails #474

Merged

Conversation

phvalguima
Copy link
Contributor

@phvalguima phvalguima commented Oct 11, 2024

This PR will add some extra logging so we can follow-up with any failures due to index creation.

…ction

Currently, only the leader unit executes the index creation. This should be kept. However, we must avoid a situation where:

1) unit 1 (leader) - successfully creates index
2) unit 2 is elected leader
3) unit 2 (leader) tries to create the index again and fails

The case (3) will trigger a deferral and rerun. Besides, it will continually try to recreate the same index.
@phvalguima phvalguima changed the title [DPE-5657] Fix race of client index creation and leader election Increase logging when index creation fails Oct 12, 2024
Copy link
Contributor

@Mehdi-Bendriss Mehdi-Bendriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open a following PR - with a rollback to this temporary change so we don't forget about it.

@phvalguima phvalguima merged commit 21e9b11 into 2/edge Oct 14, 2024
37 of 40 checks passed
@phvalguima phvalguima deleted the DPE-5657-avoid-race-between-leader_elected-index_requested branch October 14, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants