You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove redundant test case TestFakeCommandWithReaper.
---
It appears there is some history with properly awaiting faked commands
with the old shellcheck logic and using the reaper (see
#247 and
#281) but it appears this code
has been removed. Looking at the rationale for removing shellcheck in
#381, and not wanting
FakeCommand to be reaper aware, this test likely should have been
removed at that time. Additionally, this code does not appear to test
anything unique compared to the exec.Command.Run() style test as
written.
Theoretically this test isn't hurting anything but the meta context here
is that we would like to copy the testutil package over to
[x-go](https://github.com/canonical/x-go/) and not have extra
dependencies unless we really need it.
0 commit comments