Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cluster fixes #518

Merged
merged 9 commits into from
Oct 20, 2022
Merged

Conversation

simondeziel
Copy link
Member

No description provided.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel simondeziel marked this pull request as draft October 19, 2022 22:19
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel simondeziel force-pushed the more-cluster-fixes branch 5 times, most recently from 5e3b9a2 to 4a574ab Compare October 19, 2022 23:25
Testing with older (3.6) and newer (3.10) should be enough
and covers the versions shipped by Ubuntu supported releases.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel simondeziel force-pushed the more-cluster-fixes branch 2 times, most recently from 8ad1540 to 1639dec Compare October 19, 2022 23:32
…tests

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Merging #518 (067b2e9) into master (b464b17) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #518   +/-   ##
=======================================
  Coverage   97.06%   97.07%           
=======================================
  Files          56       56           
  Lines        4124     4138   +14     
=======================================
+ Hits         4003     4017   +14     
  Misses        121      121           
Impacted Files Coverage Δ
pylxd/models/cluster.py 93.75% <100.00%> (+0.20%) ⬆️
pylxd/models/instance.py 95.75% <100.00%> (+0.01%) ⬆️
pylxd/models/tests/test_cluster.py 100.00% <100.00%> (ø)
pylxd/models/tests/test_cluster_certificate.py 100.00% <100.00%> (ø)
pylxd/models/tests/test_storage.py 100.00% <100.00%> (ø)
pylxd/tests/testing.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@simondeziel simondeziel marked this pull request as ready for review October 19, 2022 23:35
@stgraber stgraber merged commit 82b2d1d into canonical:master Oct 20, 2022
@simondeziel simondeziel deleted the more-cluster-fixes branch October 20, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants