Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxc cluster enable #519

Merged
merged 3 commits into from
Oct 22, 2022
Merged

Conversation

simondeziel
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Merging #519 (df5909e) into master (82b2d1d) will decrease coverage by 0.11%.
The diff coverage is 61.53%.

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
- Coverage   97.07%   96.96%   -0.12%     
==========================================
  Files          56       56              
  Lines        4138     4151      +13     
==========================================
+ Hits         4017     4025       +8     
- Misses        121      126       +5     
Impacted Files Coverage Δ
pylxd/models/cluster.py 87.50% <37.50%> (-6.25%) ⬇️
pylxd/models/tests/test_cluster.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Equivalent of `lxc cluster enable $foo`

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel simondeziel force-pushed the lxc-cluster-enable branch 3 times, most recently from 450b86e to e05d4c1 Compare October 20, 2022 21:56
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel simondeziel force-pushed the lxc-cluster-enable branch 8 times, most recently from 7d8fd74 to add7d92 Compare October 21, 2022 12:43
Don't actually mock the Cluster.enable() call at least check
if the required API extension is present.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel simondeziel marked this pull request as ready for review October 21, 2022 13:06
@stgraber stgraber merged commit 9c58088 into canonical:master Oct 22, 2022
@simondeziel simondeziel deleted the lxc-cluster-enable branch October 23, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants