instance(all): added passing recursion to all method to get all information in instance #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markylaing
requested changes
Jul 11, 2023
There was a problem hiding this comment.
@MrDaGree thank you for adding this. Prefetching instance attributes will certainly make the client more efficient!
I've just left a couple of comments that I think will help with readability.
|
Thank you for the feed back! Ill get this worked in here shortly for another review |
|
The changes look great thanks. Could you please squash the two commits into one though? Thanks. |
MrDaGree
force-pushed
the
dgreeley-instance-all-recursion
branch
from
bb993a3
to
3b7ba60
Compare
|
Wonderful! Squashed |
|
Ahh we've renamed |
|
Sounds good. I've subscribed myself so then I can get notification of that so I am on top of this |
…mation in instance Signed-off-by: Dawson Greeley <dawsonmax10@gmail.com>
MrDaGree
force-pushed
the
dgreeley-instance-all-recursion
branch
from
3b7ba60
to
98ff395
Compare
|
Rebased from the merge of #552 |
simondeziel
added a commit
to simondeziel/pylxd
that referenced
this pull request
Jul 13, 2023
This fixes `tox -e coverage`. This was not caught when introduced by PR canonical#551 because we our CI job was still only triggering on the old branch name. The CI job was fixed afterward by commit 094bab4. The decision to omit the recursion param was taken because that's easier than trying to fix the mocked HTTP responses. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
simondeziel
added a commit
to simondeziel/pylxd
that referenced
this pull request
Jul 13, 2023
This fixes `tox -e coverage`. This was not caught when introduced by PR canonical#551 because we our CI job was still only triggering on the old branch name. The CI job was fixed afterward by commit 094bab4. The decision to omit the recursion param was taken because that's easier than trying to fix the mocked HTTP responses. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #548.
I have a project that I am working on that needs to support multi threading. Having pylxd make multiple http calls unfortunately makes my project a lot more complicated due to this. Instead of making something hacky in my project I decided to implement this to help my project and also implement more of the core LXD api.
Current implementation of
instances.all()With this PR: