Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Run integration tests #555

Merged
merged 11 commits into from
Jul 14, 2023
Merged

Conversation

simondeziel
Copy link
Member

@simondeziel simondeziel commented Jul 13, 2023

A bunch of other fixes are also bundled in this PR but the biggest change is the integration tests being run on push/PR.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #555 (a89d4cf) into main (796f3f3) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
- Coverage   97.25%   97.25%   -0.01%     
==========================================
  Files          56       56              
  Lines        4262     4261       -1     
==========================================
- Hits         4145     4144       -1     
  Misses        117      117              
Impacted Files Coverage Δ
pylxd/client.py 90.12% <ø> (-0.05%) ⬇️

@simondeziel simondeziel force-pushed the integration branch 2 times, most recently from bedc4bf to 0500240 Compare July 13, 2023 15:22
…able

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…to running tests

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
LXD 3.0 is no longer supported, see:
https://discuss.linuxcontainers.org/t/lxc-lxd-lxcfs-3-0-end-of-life-announcement/17600

This reverts commit 1c442f0.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Python 3.6 made sense when Ubuntu 18.04 was still support but that
ended in May 2023.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
This aligns better with LXD Github CI.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
This fixes commit e7d13e3

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel simondeziel changed the title Integration github: Run integration tests Jul 13, 2023
@simondeziel simondeziel marked this pull request as ready for review July 13, 2023 16:04
@tomponline tomponline merged commit 89617a6 into canonical:main Jul 14, 2023
@simondeziel simondeziel deleted the integration branch July 14, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants