Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the profile description upon creation #566

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

simondeziel
Copy link
Member

No description provided.

Closes canonical#565

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #566 (559eeab) into main (761d965) will decrease coverage by 0.04%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #566      +/-   ##
==========================================
- Coverage   97.80%   97.77%   -0.04%     
==========================================
  Files          32       32              
  Lines        3055     3057       +2     
==========================================
+ Hits         2988     2989       +1     
- Misses         67       68       +1     
Files Coverage Δ
pylxd/models/profile.py 97.72% <66.66%> (-2.28%) ⬇️

@simondeziel simondeziel marked this pull request as ready for review October 23, 2023 13:31
Copy link
Member

@MusicDin MusicDin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simondeziel simondeziel merged commit c758ad5 into canonical:main Nov 13, 2023
8 of 10 checks passed
@simondeziel simondeziel deleted the profile-description branch November 13, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants