Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

Only include AIO syscall wrappers on Linux #131

Merged
merged 1 commit into from
Apr 18, 2020
Merged

Only include AIO syscall wrappers on Linux #131

merged 1 commit into from
Apr 18, 2020

Conversation

freeekanayaka
Copy link
Contributor

Fixes #125.

@brauner
Copy link
Contributor

brauner commented Apr 18, 2020

The travis complaint is a bit weird. Mergeable despite the failure?

@freeekanayaka
Copy link
Contributor Author

The travis complaint is a bit weird. Mergeable despite the failure?

Oh yeah, good catch. I forgot to add -DHAVE_LINUX_AIO_ABI_H when compiling the amalgamated single-source file.

Travis is happy now, should be good to merge, thanks.

@brauner brauner merged commit 88e3eab into canonical:master Apr 18, 2020
@Kerollmops
Copy link

Kerollmops commented Apr 18, 2020

There also is an import of <linux/aio_abi.h> in the uv_os.h file. Is it meant to be fixed by this PR?

EDIT: I just read #125 and IIUC it is only meant to make the project compile when libuv is disabled!

@freeekanayaka
Copy link
Contributor Author

There also is an import of <linux/aio_abi.h> in the uv_os.h file. Is it meant to be fixed by this PR?

Not for now. If you build uv support for now you need linux. Perhaps this could be fixed by the windows port PR.

@freeekanayaka
Copy link
Contributor Author

freeekanayaka commented Apr 18, 2020

There also is an import of <linux/aio_abi.h> in the uv_os.h file. Is it meant to be fixed by this PR?

Not for now. If you build uv support for now you need linux. Perhaps this could be fixed by the windows port PR.

(this PR is only meant to support building without uv on non-linux)

@freeekanayaka freeekanayaka deleted the feature-detect-linux-aio branch April 20, 2020 10:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It seems that syscall is only required in uv_*.c
3 participants