This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
uv_append: Don't finalize segment if there are writes in-flight #265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calling
uvAliveSegmentFinalize(s)
while there are writes against the alive segment in flight could lead touvWriterClose
being called twice, leading to a triggered assertionsrc/uv_writer.c:393: UvWriterClose: Assertion '!w->closing' failed.
This can happen when e.g.:
uvAliveSegmentWriteCb
poll_queue
uvAliveSegmentFinalize(s)
to be called herepoll_queue
UvWriterClose
being called again.To avoid this, no longer finalize the alive segment if there is a write in-flight, checked by comparing
pending_last_index
&last_index
on the segment. When the in-flight write completes, the segment will be finalized.