This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Config rollback #354
Merged
Config rollback #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
==========================================
+ Coverage 84.01% 84.22% +0.20%
==========================================
Files 50 50
Lines 9461 9521 +60
Branches 2525 2552 +27
==========================================
+ Hits 7949 8019 +70
+ Misses 938 921 -17
- Partials 574 581 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MathieuBordere
force-pushed
the
config-rollback
branch
from
d070881
to
e698f79
Compare
|
Looks to be misbehaving in Jepsen suite with a lot of |
MathieuBordere
force-pushed
the
config-rollback
branch
5 times, most recently
from
6d1a15a
to
3f9596d
Compare
|
Jepsen looks fine now. |
MathieuBordere
force-pushed
the
config-rollback
branch
from
3f9596d
to
88544a5
Compare
added 5 commits
January 11, 2023 09:00
Signed-off-by: Mathieu Borderé <mathieu.bordere@canonical.com>
Signed-off-by: Mathieu Borderé <mathieu.bordere@canonical.com>
Signed-off-by: Mathieu Borderé <mathieu.bordere@canonical.com>
Signed-off-by: Mathieu Borderé <mathieu.bordere@canonical.com>
Signed-off-by: Mathieu Borderé <mathieu.bordere@canonical.com>
MathieuBordere
force-pushed
the
config-rollback
branch
from
88544a5
to
baa8f52
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
Set
configuration_uncommitted_indexupon startup as we can't know if the configuration is committed or not.Backup the configuration in case the configuration entry is no longer present in the log.
Only store committed configurations in a snapshot and not the latest available configuration.
Fixes #250