Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix deprecated act usage warning #1085

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented May 14, 2024

Done

This PR fixes deprecation warning about act usage from react-dom/test-utils

  • test: test: fix deprecated act usage warning
    • update act import from react
    • remove act in favour of async userEvent

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Steps for QA.

Percy steps

  • List any expected visual change in Percy, or write something like "No visual changes expected" if none is expected.

Fixes

Fixes: # .

@webteam-app
Copy link

Copy link

This PR is being prevented from merging because it needs to be reviewed on Percy.

Go to Percy, find the build relevant to this PR and check if it looks as expected.

Once it's approved, add the label Review: Percy +1 to this PR.

Signed-off-by: Peter Makowski <me+git@petermakowski.io>
@petermakowski petermakowski changed the title test: remove act in favour of async timers test: fix deprecated act usage warning May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants