oci: handle opaque whiteouts in new layer (usrmerge) #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that add_layer() looks at the base, improve its logic to support *explicit* removals/hiding of base layer symlinks. With this change, regular directories created by lifecycle's "build" step will respect symlinks in the base layer, but removals via overlay-scripts will hide those symlinks.
tigarmo
force-pushed
the
CRAFT-1527-usrmerge-overlays
branch
from
96a7fa2
to
87e0d99
Compare
tigarmo
changed the title
tigarmo
requested review from
cmatsuoka and
cjdcordeiro
and removed request for
cmatsuoka
tigarmo
commented
Dec 9, 2022
cjdcordeiro
reviewed
Dec 12, 2022
cmatsuoka
approved these changes
Dec 14, 2022
tigarmo
force-pushed
the
CRAFT-1527-usrmerge-overlays
branch
from
cd92840
to
7496791
Compare
cjdcordeiro
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
good enough for now, considering that the limitations addressed in #163 (comment) should be fixed asap
This was referenced Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that add_layer() looks at the base, improve its logic to support
explicit removals/hiding of base layer symlinks. With this change,
regular directories created by lifecycle's "build" step will respect
symlinks in the base layer, but removals via overlay-scripts will
hide those symlinks.
(CRAFT-1527)