-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: add base
as a type and top level property
#1419
Conversation
Thanks for the contribution. The tests failed because your commit in the email has not signed the CLA, you can either sign it with your @ubuntu.com account or use your @canonical.com email to author the commit. |
The contributor agreement thing is hopefully sorted now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change @mvo5!
This needs a user test. Ideally, this would call snapcraft with a different base and execute it. We have snaps_tests for this things, but I'm not sure how easy would it be to automate. If it's too complex, we always have manual_tests.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the branch on snapd
where you mention the dependency on this one you also use base
as a type. I don't see that reflected here.
base
as a type and top level property
Thanks for the feedback and sorry for the delay, I was on vacation. I added the "base" to the support types now and also added tests to snaps_tests as suggested. This will validate that the snaps can be build and installed. If you need more tests, please let me know. |
Thanks for helping us make a better Snapcraft!
LP: #1706564