Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add base as a type and top level property #1419

Merged
merged 8 commits into from
Aug 15, 2017

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Jul 26, 2017

Thanks for helping us make a better Snapcraft!

LP: #1706564

@sergiusens
Copy link
Collaborator

Thanks for the contribution. The tests failed because your commit in the email has not signed the CLA, you can either sign it with your @ubuntu.com account or use your @canonical.com email to author the commit.

@mvo5
Copy link
Contributor Author

mvo5 commented Jul 26, 2017

The contributor agreement thing is hopefully sorted now.

Copy link
Contributor

@come-maiz come-maiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change @mvo5!
This needs a user test. Ideally, this would call snapcraft with a different base and execute it. We have snaps_tests for this things, but I'm not sure how easy would it be to automate. If it's too complex, we always have manual_tests.md

@sergiusens sergiusens added this to the 2.34 milestone Aug 3, 2017
Copy link
Collaborator

@sergiusens sergiusens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the branch on snapd where you mention the dependency on this one you also use base as a type. I don't see that reflected here.

@sergiusens sergiusens changed the title add "base" to the snapcraft.yaml schema meta: add base as a type and top level property Aug 3, 2017
@mvo5
Copy link
Contributor Author

mvo5 commented Aug 9, 2017

Thanks for the feedback and sorry for the delay, I was on vacation.

I added the "base" to the support types now and also added tests to snaps_tests as suggested. This will validate that the snaps can be build and installed. If you need more tests, please let me know.

@sergiusens sergiusens dismissed come-maiz’s stale review August 15, 2017 17:36

the tests were added

@sergiusens sergiusens merged commit 024b920 into canonical:master Aug 15, 2017
kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants