Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-2131][BUGFIX] lightkube rolebindnig broken #19

Merged
merged 3 commits into from
Jun 16, 2023
Merged

[DPE-2131][BUGFIX] lightkube rolebindnig broken #19

merged 3 commits into from
Jun 16, 2023

Conversation

juditnovak
Copy link
Contributor

@juditnovak juditnovak commented Jun 15, 2023 •
edited
Loading

On namespace creation the follwing error ocurred:

FAILED tests/integration/test_registry.py::TestRegistry::test_registry_change_primary_account_1_spark_namespace - lightkube.core.exceptions.ApiError: RoleBinding.rbac.authorization.k8s.io "spark-user-1-role-binding" is invalid: subjects[0].name: Required value

@juditnovak juditnovak force-pushed the DPE-2131_lightkube_rolebindnig_broken branch from 6654bfc to 37e4d46 Compare June 15, 2023 23:52
@juditnovak juditnovak force-pushed the DPE-2131_lightkube_rolebindnig_broken branch from 37e4d46 to 8d79d2d Compare June 16, 2023 00:03
@juditnovak juditnovak marked this pull request as ready for review June 16, 2023 00:04
@juditnovak juditnovak requested a review from deusebio June 16, 2023 00:04
@juditnovak juditnovak force-pushed the DPE-2021_integration_tests_lightkube_registry branch 2 times, most recently from 4430373 to 7bc7d7b Compare June 16, 2023 00:48
@juditnovak juditnovak force-pushed the DPE-2131_lightkube_rolebindnig_broken branch 3 times, most recently from e7a1d0c to 29b14bc Compare June 16, 2023 12:54
deusebio
deusebio approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@deusebio deusebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

marcoppenheimer
marcoppenheimer approved these changes Jun 16, 2023
View reviewed changes
spark8t/services.py Show resolved Hide resolved
spark8t/services.py Outdated Show resolved Hide resolved
spark8t/services.py Outdated Show resolved Hide resolved
tests/integration/test_registry.py Show resolved Hide resolved
@juditnovak juditnovak force-pushed the DPE-2021_integration_tests_lightkube_registry branch from 7bc7d7b to e100c88 Compare June 16, 2023 15:28
Base automatically changed from DPE-2021_integration_tests_lightkube_registry to main June 16, 2023 15:49
@juditnovak juditnovak force-pushed the DPE-2131_lightkube_rolebindnig_broken branch from 29b14bc to 369e50e Compare June 16, 2023 15:51
@juditnovak juditnovak force-pushed the DPE-2131_lightkube_rolebindnig_broken branch from 369e50e to 2484417 Compare June 16, 2023 17:06
@juditnovak juditnovak merged commit b8b3793 into main Jun 16, 2023
@juditnovak juditnovak deleted the DPE-2131_lightkube_rolebindnig_broken branch June 16, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deusebio deusebio deusebio approved these changes

@marcoppenheimer marcoppenheimer marcoppenheimer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juditnovak @deusebio @marcoppenheimer