Lp 1960162 #1181
Merged
Lp 1960162 #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbungert
force-pushed
the
lp-1960162
branch
2 times, most recently
from
352c286
to
557bd6e
Compare
|
I think this looks basically ok. Can we change answers/guided-lvm.yaml to request encryption with a password of "passw0rd" so the grepping scripts/runtests.sh does will guard against regression? |
ogayot
approved these changes
Feb 9, 2022
ogayot
reviewed
Feb 11, 2022
Some API methods have sensitive information in the body of the call. Stop logging the body unconditionally.
Add body logging for POST methods that accept a Payload for data. Use repr=False on UbuntuAdvantageForm to not log the token.
jpnurmi
added a commit
to jpnurmi/ubuntu-desktop-installer
that referenced
this pull request
Mar 7, 2022
jpnurmi
added a commit
to jpnurmi/ubuntu-desktop-installer
that referenced
this pull request
Mar 8, 2022
jpnurmi
added a commit
to jpnurmi/ubuntu-desktop-installer
that referenced
this pull request
Mar 8, 2022
jpnurmi
added a commit
to jpnurmi/ubuntu-desktop-installer
that referenced
this pull request
Mar 9, 2022
jpnurmi
added a commit
to jpnurmi/ubuntu-desktop-installer
that referenced
this pull request
Mar 9, 2022
jpnurmi
added a commit
to jpnurmi/ubuntu-desktop-installer
that referenced
this pull request
Mar 9, 2022
jpnurmi
added a commit
to canonical/ubuntu-desktop-installer
that referenced
this pull request
Mar 18, 2022
* Update subiquity submodule * subiquity_client: change storage/v2/guided from request params to body (canonical/subiquity#1181) * subiquity_client: add Gap object (canonical/subiquity#1176) * ubuntu_desktop_installer: adapt to Disk.objects/partitions API changes * CI: prepare environment for subiquity (canonical/subiquity#1185) * subiquity_client: add Partition.offset * Update snap config
jpnurmi
added a commit
to canonical/subiquity_client.dart
that referenced
this pull request
Feb 1, 2023
* Update subiquity submodule * subiquity_client: change storage/v2/guided from request params to body (canonical/subiquity#1181) * subiquity_client: add Gap object (canonical/subiquity#1176) * ubuntu_desktop_installer: adapt to Disk.objects/partitions API changes * CI: prepare environment for subiquity (canonical/subiquity#1185) * subiquity_client: add Partition.offset * Update snap config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.