Permit ESP on Raid if PowerEdge #1745
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwhudson
approved these changes
Jul 26, 2023
ogayot
reviewed
Jul 27, 2023
| :param key: dmidecode(8) KEYWORD | ||
| :returns: stripped string output, or empty string on failure | ||
| """ | ||
| sp = run_command(["dmidecode", "-s", key], check=False, text=True) |
There was a problem hiding this comment.
should we add dmidecode to the apt dependencies list ?
If the command is not found, this will raise a FileNotFoundError.
dbungert
force-pushed
the
lp-1961079-esp-on-mdraid-poweredge
branch
from
fe66e0a
to
67f6f67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in LP: #1961079, permit bootable raid if the system appears to be a "PowerEdge".
Tested by way of CI, added unit tests, and a quick VM smoke test.