update charms.traefik_route_k8s.v0.traefik_route library #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rbarry82
approved these changes
Nov 29, 2022
sed-i
reviewed
Nov 29, 2022
|
|
||
|
|
||
| async def safe_relate(ops_test: OpsTest, ep1, ep2): | ||
| # in pytest-operator CI, we deploy all tests in the same model. |
There was a problem hiding this comment.
I think deploying all itests in the same model is not a justification but rather something to avoid.
The introduction of deploy_traefik_if_not_deployed and deploy_charm_if_not_deployed seems to me like an antipattern that should be avoided.
In the past we were trying out reset but it wasn't very stable. If we add a preserve keyword to reset perhaps we could try again.
There was a problem hiding this comment.
Yeah in hindsight I'd avoid all of that. Models are cheap, I keep forgetting that.
Not in this PR though :D
simskij
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #106.
Release Notes
Update the version of the
charms.traefik_route_k8s.v0.traefik_routelibrary to the latest one.